A Mono/C# port of the Platform.gd script and using enums#1
Open
RaoulMarz wants to merge 1 commit into
Open
Conversation
Author
|
This port has most of the functionality but not the tool integration like the Gdscript version has. |
Owner
|
@RaoulMarz Thanks for this! I'll think how to best integrate this. What version of Godot did you make this with? |
ee0pdt
reviewed
Jan 14, 2020
|
|
||
| namespace Platforms.Enums | ||
| { | ||
| public enum AlignmentArea |
Owner
There was a problem hiding this comment.
Nothing currently references this enum?
Author
|
Sorry I copied my Enums folder from another project and forget to remove
that "AlignmentArea" enum. At one point I was thinking of possibly making
use of it, but didn't, and subsequently forgot about it.
I will go through your latest update with the player etc. and see about
porting that in the next day or so.
…On Tue, Jan 14, 2020 at 1:58 PM Pete Thorne ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Enums/AlignmentArea.cs
<#1 (comment)>
:
> @@ -0,0 +1,12 @@
+using System;
+
+namespace Platforms.Enums
+{
+ public enum AlignmentArea
Nothing currently references this enum?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AFMBR3FROAF24LIRYOGZH5TQ5WSHZA5CNFSM4KGDLAY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRU5LIA#pullrequestreview-342480288>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMBR3G7P36ROLD3LYINMDTQ5WSHZANCNFSM4KGDLAYQ>
.
|
Author
|
I am just more than halfway with porting the player and follow_camera
scripts. I will duplicate your main scene and then duplicate and rename the
player and other scenes that attaches to c# instead of GDScript.
So everything I modify will be duplicates, that I rename. The naming will
be as follows, "Mono_Main.tscn", "Mono_Player.scn", "Mono_Platform.tscn"
etc.. This way there will be no interference with your current code.
To then try out the Mono/C# port, you change just change the main scene in
the project settings to "Mono_Main.tscn", and all the mono code will be
used then.
…On Tue, Jan 14, 2020 at 1:58 PM Pete Thorne ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Enums/AlignmentArea.cs
<#1 (comment)>
:
> @@ -0,0 +1,12 @@
+using System;
+
+namespace Platforms.Enums
+{
+ public enum AlignmentArea
Nothing currently references this enum?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AFMBR3FROAF24LIRYOGZH5TQ5WSHZA5CNFSM4KGDLAY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRU5LIA#pullrequestreview-342480288>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMBR3G7P36ROLD3LYINMDTQ5WSHZANCNFSM4KGDLAYQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Mono/C# port of the Platform.gd script and relevant separation of enums.