Fix connector state crash

Author: tiberiuichim

backend/onyx/server/manage/connectors_state.py

@@ -25,9 +25,8 @@
 from onyx.redis.redis_connector_utils import get_deletion_attempt_snapshot
 from onyx.server.documents.models import IndexAttemptSnapshot
 
-def get_connectors_state(
-    db_session, tenant_id
-) -> list[ConnectorIndexingStatus]:
+
+def get_connectors_state(db_session, tenant_id) -> list[ConnectorIndexingStatus]:
     indexing_statuses: list[ConnectorIndexingStatus] = []
 
     user = None
@@ -42,14 +41,13 @@ def get_connectors_state(
     # to avoid the complexity of trying to error check throughout the function
     cc_pairs = get_connector_credential_pairs(
         db_session=db_session,
-#        user=user,
-#        get_editable=False,
+        #        user=user,
+        #        get_editable=False,
     )
 
     cc_pair_identifiers = [
         ConnectorCredentialPairIdentifier(
-            connector_id=cc_pair.connector_id, credential_id=cc_pair.credential_id
-        )
+            connector_id=cc_pair.connector_id, credential_id=cc_pair.credential_id)
         for cc_pair in cc_pairs
     ]
 
@@ -68,22 +66,19 @@ def get_connectors_state(
 
     document_count_info = get_document_counts_for_cc_pairs(
         db_session=db_session,
-        cc_pair_identifiers=cc_pair_identifiers,
+        cc_pairs=cc_pair_identifiers,
     )
-    cc_pair_to_document_cnt = {
-        (connector_id, credential_id): cnt
-        for connector_id, credential_id, cnt in document_count_info
-    }
+    cc_pair_to_document_cnt = {(connector_id, credential_id)
+                                : cnt for connector_id, credential_id, cnt in document_count_info}
 
     group_cc_pair_relationships = get_cc_pair_groups_for_ids(
         db_session=db_session,
         cc_pair_ids=[cc_pair.id for cc_pair in cc_pairs],
     )
     group_cc_pair_relationships_dict: dict[int, list[int]] = {}
     for relationship in group_cc_pair_relationships:
-        group_cc_pair_relationships_dict.setdefault(relationship.cc_pair_id, []).append(
-            relationship.user_group_id
-        )
+        group_cc_pair_relationships_dict.setdefault(
+            relationship.cc_pair_id, []).append(relationship.user_group_id)
 
     search_settings: SearchSettings | None = None
     if not secondary_index:
@@ -105,18 +100,18 @@ def get_connectors_state(
         in_progress = False
         if search_settings:
             redis_connector = RedisConnector(tenant_id, cc_pair.id)
-            redis_connector_index = redis_connector.new_index(search_settings.id)
+            redis_connector_index = redis_connector.new_index(
+                search_settings.id)
             if redis_connector_index.fenced:
                 in_progress = True
 
-#        if search_settings:
-#            rci = RedisConnectorIndexing(cc_pair.id, search_settings.id)
-#            if r.exists(rci.fence_key):
-#                in_progress = True
+        #        if search_settings:
+        #            rci = RedisConnectorIndexing(cc_pair.id, search_settings.id)
+        #            if r.exists(rci.fence_key):
+        #                in_progress = True
 
         latest_index_attempt = cc_pair_to_latest_index_attempt.get(
-            (connector.id, credential.id)
-        )
+            (connector.id, credential.id))
 
         latest_finished_attempt = get_latest_index_attempt_for_cc_pair_id(
             db_session=db_session,
@@ -131,29 +126,23 @@ def get_connectors_state(
                 name=cc_pair.name,
                 cc_pair_status=cc_pair.status,
                 connector=ConnectorSnapshot.from_connector_db_model(connector),
-                credential=CredentialSnapshot.from_credential_db_model(credential),
+                credential=CredentialSnapshot.from_credential_db_model(
+                    credential),
                 access_type=cc_pair.access_type,
                 owner=credential.user.email if credential.user else "",
                 groups=group_cc_pair_relationships_dict.get(cc_pair.id, []),
                 last_finished_status=(
-                    latest_finished_attempt.status if latest_finished_attempt else None
-                ),
+                    latest_finished_attempt.status if latest_finished_attempt else None),
                 last_status=(
-                    latest_index_attempt.status if latest_index_attempt else None
-                ),
+                    latest_index_attempt.status if latest_index_attempt else None),
                 last_success=cc_pair.last_successful_index_time,
                 docs_indexed=cc_pair_to_document_cnt.get(
-                    (connector.id, credential.id), 0
-                ),
+                    (connector.id, credential.id), 0),
                 error_msg=(
-                    latest_index_attempt.error_msg if latest_index_attempt else None
-                ),
+                    latest_index_attempt.error_msg if latest_index_attempt else None),
                 latest_index_attempt=(
                     IndexAttemptSnapshot.from_index_attempt_db_model(
-                        latest_index_attempt
-                    )
-                    if latest_index_attempt
-                    else None
+                        latest_index_attempt) if latest_index_attempt else None
                 ),
                 deletion_attempt=get_deletion_attempt_snapshot(
                     connector_id=connector.id,