Skip to content

Convert the bin entry to TypeScript#679

Closed
remcohaszing wants to merge 1 commit into
eemeli:mainfrom
remcohaszing:bin-ts
Closed

Convert the bin entry to TypeScript#679
remcohaszing wants to merge 1 commit into
eemeli:mainfrom
remcohaszing:bin-ts

Conversation

@remcohaszing
Copy link
Copy Markdown

This means it’s type checked. There’s no need to have this particular file as JavaScript.

This means it’s type checked. There’s no need to have this particular
file as JavaScript.
Copy link
Copy Markdown
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? There's no benefit to this change. Note how even the updated contents are valid JS.

@remcohaszing
Copy link
Copy Markdown
Author

I don’t see a reason to treat the bin entry different from any other part of the source code. With this change, the file is both type checked and linted.

This just seemed like a small improvement I noticed while looking at the code base.

@eemeli
Copy link
Copy Markdown
Owner

eemeli commented May 2, 2026

The bin.js file needs to be executable. I find it much cleaner to have that be always set, rather than needing to add a post-build step for it (which this PR is currently missing, btw).

@remcohaszing
Copy link
Copy Markdown
Author

The bin.js file doesn’t need to be executable. Package managers will make sure the bin entries are executable on install. But I do agree it would be nicer if it is.

Both the benefits and drawbacks of this change are very minimal. It appears you don’t want this change, so I’ll just close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants