fix(nat-pmp): avoid polling same future multiple times#371
Open
Filang666 wants to merge 3 commits into
Open
Conversation
fix(nat-pmp): recreate future on each retry to avoid illegal polling Previously, `with_retries_and_timeout` polled the same future multiple times, causing a panic. Now it accepts a closure that returns a fresh future on each attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The with_retries_and_timeout function polls the same future repeatedly, which is illegal in async Rust and causes a panic async fn resumed after completion from the natpmp crate.
This PR removes that function and inlines retry+timeout loops directly into each operation, creating a fresh future on every attempt.
Result: no more panic. NAT-PMP works (or correctly falls back to UPnP).
Tested locally with a router that does not support NAT-PMP – fallback to UPnP works, no crash.