Merge pull request OP-Engineering#280 from OP-Engineering/oscar/fix-incorrect-crsqlite

ospfranco · web-flow · commit d4cd4419b6b5 · 2025-05-21T17:28:47.000+02:00
Throw error instead of returning non-existing enum
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+v20
diff --git a/cpp/libsql/bridge.cpp b/cpp/libsql/bridge.cpp
@@ -100,7 +100,7 @@ DB opsqlite_libsql_open(std::string const &name, std::string const &last_path,
                                    &errMsg);
 
     if (status != 0) {
-        return {.type = SQLiteError, .message = errMsg};
+        throw std::runtime_error(errMsg);
     } else {
         LOGI("Loaded CRSQlite successfully");
     }

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ DB opsqlite_libsql_open(std::string const &name, std::string const &last_path,`
`100`	`100`	`&errMsg);`
`101`	`101`
`102`	`102`	`if (status != 0) {`
`103`		`- return {.type = SQLiteError, .message = errMsg};`
	`103`	`+ throw std::runtime_error(errMsg);`
`104`	`104`	`} else {`
`105`	`105`	`LOGI("Loaded CRSQlite successfully");`
`106`	`106`	`}`