Skip to content

Commit 6132a0f

Browse files
Remove TODOs
1 parent 3713952 commit 6132a0f

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

effekt/shared/src/main/scala/effekt/Typer.scala

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,9 +1471,7 @@ object Typer extends Phase[NameResolved, Typechecked] {
14711471
def instantiateImplicitBlock(b: source.Term, tpe: symbols.BlockType)(using Context): source.Term = {
14721472
if(!Context.messaging.hasErrors) {
14731473
(b, tpe) match {
1474-
// TODO move the instantiation down to when we have the types?
14751474
case (a, symbols.BlockType.FunctionType(tps, cps, vps, bps, res, effs)) =>
1476-
// TODO prevent infinite recursion due to this
14771475
a match {
14781476
case source.BlockLiteral(tparams, vparams, bparams, source.Return(source.Call(fn, targs, vargs, bargs, _), _), _) =>
14791477
// We need to refresh the whole binding structure, so we don't have duplicate stuff in the tree.
@@ -1521,19 +1519,16 @@ object Typer extends Phase[NameResolved, Typechecked] {
15211519
case _ => Context.panic("Unexpected implicit value for implicit block parameter")
15221520
}
15231521
case (a, symbols.BlockType.InterfaceType(tCons, tArgs)) =>
1524-
// TODO prevent infinite recursion due to this
1525-
// TODO rename everything to use fresh names (preserving Namer results)
1526-
// TODO instantiate / substitute types here
1522+
// There is nothing to do here
15271523
a
15281524
}
15291525
} else {
15301526
Context.abort("Not instantiating implicit block argument since there are errors.")
15311527
}
15321528
}
1533-
def instantiateImplicitValue(b: source.ValueArg, tpe: symbols.ValueType)(using Context): source.ValueArg = {
1534-
// TODO rename everything to use fresh names (preserving Namer results)
1535-
// TODO instantiate / substitute types here
1536-
b
1529+
def instantiateImplicitValue(v: source.ValueArg, tpe: symbols.ValueType)(using Context): source.ValueArg = {
1530+
// There is nothing to do here
1531+
v
15371532
}
15381533

15391534
def checkCallTo(

0 commit comments

Comments
 (0)