Experiment: annotate hot paths on LLVM#1384
Draft
jiribenes wants to merge 4 commits into
Draft
Conversation
f881e45 to
001f6b1
Compare
001f6b1 to
b6f26ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My local devenv is broken so I can't benchmark this; we should really benchmark each commit individually against
mainto see if we get some perf.There are three main changes:
assume RC ≥ 0 (not obvious to LLVM since we use a wholeEDIT: removed this via a force push for now, diff herei64)assume that a to-be-erased value is non-nullEDIT: not true, we even emit themnullsometimes... diff hereI think these are all valid assumptions / hot paths that we should prefer.
EDIT: The crossed out changes above kept the CI in a busy loop somehow 🔁