Fix get_ticket_by_id output validation#29
Open
oijkn wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes MCP output validation for get_ticket_by_id by restoring structured output registration, ensuring the tool can return Freshservice’s JSON object without being validated as plain text.
Changes:
- Register
get_ticket_by_idwith the default@mcp.tool()decorator to enable structured output validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_ticket_by_idby registering it with the default@mcp.tool()decorator.Root cause
get_ticket_by_idreturnsresponse.json()as a dictionary, but it was registered withstructured_output=False, which causes the MCP runtime to validate the result as unstructured text.Validation
python -m py_compile src/freshservice_mcp/server.pysuccessfully.