Skip to content

Testing framework#1902

Open
thommey wants to merge 11 commits into
developfrom
testing-framework
Open

Testing framework#1902
thommey wants to merge 11 commits into
developfrom
testing-framework

Conversation

@thommey
Copy link
Copy Markdown
Member

@thommey thommey commented May 2, 2026

One-line summary: AI written pytest based tests for Eggdrop. No changes to Eggdrop source code. uv is recommended but not required to run them.

Additional description (if needed): In the future we can add Tcl commands to introspect C state, guarded by #ifdef TESTING only. See testing/README.md for a longer description and architectural details.

It pretty much does what the eggdrop-test repository did with a few more modern changes:

  • a socket to execute arbitrary Tcl commands
  • run with -nt to have owner partyline access
  • jinja2 templates for config/userfile
  • temporary directory per test run (easy inspection on failure)
  • simulate ircd that eggdrop connects to
  • flexible verification with the ircd reading lines or Tcl commands or partyline commands or logs

Test cases demonstrating functionality (if applicable):

make distclean && ./configure --enable-coverage && make config debug && cd tests && uv run pytest

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8125556c53

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +43 to +44
if [ -s .gitdiff ]; then
exit 0; # disabled
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fail makedepend check when generated files change

The makedepend-check job now returns success even when misc/makedepend modifies tracked files, because the non-empty diff branch exits with 0. In CI this silently disables the regression guard that previously enforced committed dependency updates, so PRs can merge with stale generated dependency data and only fail later in downstream builds or packaging flows.

Useful? React with 👍 / 👎.

@thommey thommey force-pushed the testing-framework branch 3 times, most recently from b606c57 to 3884dbb Compare May 2, 2026 21:13
@thommey thommey force-pushed the testing-framework branch from f8a0cc7 to 785bb21 Compare May 4, 2026 16:39
@thommey thommey force-pushed the testing-framework branch from d7581eb to 0cc25ce Compare May 5, 2026 17:05
This perfectly finds the regression caused by 2fea6c4
which intended to fix issues with the extra ":".

Broken: 1.10.1
Valid: 1.10.0 and latest HEAD because of gotmode() using parse_irc now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant