fix(service-worker): address PR review findings

- FetchEventHandler: run initRoutes inside the try so a route-registration
  failure returns the unified 500 instead of rejecting; non-Error throws use
  String(e); merge ctx.responseHeaders via getSetCookie() so multiple Set-Cookie
  are preserved (not folded).
- ResponseUtils: return Uint8Array / ArrayBuffer / Blob / URLSearchParams /
  FormData (and any ArrayBuffer view) as a body instead of JSON-serializing.
- controller-plugin: guard `config.mcp.hooks` assignment with mcpEnable() so it
  does not throw when MCP is disabled.
- controller-runtime HTTPMethodRegister: scope hostRouter per host iteration so
  a falsy host does not inherit the previous host's router.
- wiki: bump stale updated_at on the two touched pages.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: gxkl

tegg/core/controller-runtime/src/lib/impl/http/HTTPMethodRegister.ts

@@ -61,9 +61,10 @@ export abstract class HTTPMethodRegister {
     this.checkDuplicateInRouter(this.router);
 
     // 2. check duplicate with host tegg controller
-    let hostRouter: Router | undefined;
     const hosts = this.controllerMeta.getMethodHosts(this.methodMeta) || [];
     hosts.forEach((h) => {
+      // Per-iteration so a falsy host does not inherit the previous host's router.
+      let hostRouter: Router | undefined;
       if (h) {
         hostRouter = this.checkRouters.get(h);
         if (!hostRouter) {

tegg/plugin/controller/src/app.ts

@@ -147,7 +147,11 @@ export default class ControllerAppBootHook implements ILifecycleBoot {
       this.controllerLoadUnitHandler = new ControllerLoadUnitHandler(this.app);
       await this.controllerLoadUnitHandler.ready();
 
-      this.app.config.mcp.hooks = EggMcpRouter.hooks;
+      // Guarded like every other config.mcp access — when MCP is disabled
+      // config.mcp may be absent, and there is no router to publish hooks for.
+      if (this.mcpEnable()) {
+        this.app.config.mcp.hooks = EggMcpRouter.hooks;
+      }
     });
   }
 

tegg/standalone/service-worker-controller/src/http/FetchEventHandler.ts

@@ -57,9 +57,11 @@ export class FetchEventHandler extends AbstractEventHandler<FetchEvent, Response
   }
 
   async handleEvent(event: FetchEvent): Promise<Response> {
-    await this.initRoutes();
     const ctx = this.fetchContextFactory?.create({ event }) ?? new ServiceWorkerFetchContext({ event });
     try {
+      // Inside the try so a route-registration failure returns the unified 500
+      // error shape instead of rejecting handleEvent's promise.
+      await this.initRoutes();
       await this.#routes!(ctx, async () => {
         /* noop */
       });
@@ -68,13 +70,14 @@ export class FetchEventHandler extends AbstractEventHandler<FetchEvent, Response
         return ResponseUtils.createErrorResponse(404, 'NOT_FOUND', `${ctx.method} ${ctx.path} not found`);
       }
       return await this.#guardResponseStream(this.#mergeResponseHeaders(response, ctx.responseHeaders));
-    } catch (e: any) {
+    } catch (e) {
       const mapped = this.errorResponseMapper?.toResponse(e, ctx);
       if (mapped) {
         return mapped;
       }
       console.error('[service-worker] handle fetch event failed:', e);
-      return ResponseUtils.createErrorResponse(500, 'INTERNAL_SERVER_ERROR', e?.message ?? 'internal error');
+      const message = e instanceof Error ? e.message : String(e);
+      return ResponseUtils.createErrorResponse(500, 'INTERNAL_SERVER_ERROR', message);
     }
   }
 
@@ -95,8 +98,16 @@ export class FetchEventHandler extends AbstractEventHandler<FetchEvent, Response
     }
     const headers = new Headers(response.headers);
     for (const [key, value] of extra.entries()) {
+      // `entries()` folds multiple Set-Cookie into one comma-joined value, which
+      // corrupts cookies; carry them over individually via getSetCookie().
+      if (key === 'set-cookie') {
+        continue;
+      }
       headers.set(key, value);
     }
+    for (const cookie of extra.getSetCookie()) {
+      headers.append('set-cookie', cookie);
+    }
     return new Response(response.body, {
       status: response.status,
       statusText: response.statusText,

tegg/standalone/service-worker-controller/src/utils/ResponseUtils.ts

@@ -19,7 +19,18 @@ export class ResponseUtils {
     if (typeof body === 'undefined' || body === null) {
       return new Response(null, { status: 204 });
     }
-    if (Buffer.isBuffer(body) || typeof body === 'string' || body instanceof ReadableStream) {
+    if (
+      typeof body === 'string' ||
+      body instanceof ReadableStream ||
+      // Buffer is a Uint8Array; also cover the other web-standard BodyInit types
+      // so a controller returning binary/form bodies is not JSON-serialized.
+      body instanceof Uint8Array ||
+      body instanceof ArrayBuffer ||
+      body instanceof Blob ||
+      body instanceof URLSearchParams ||
+      body instanceof FormData ||
+      ArrayBuffer.isView(body)
+    ) {
       return new Response(body as BodyInit, { status: 200 });
     }
     if (body instanceof Readable) {

tegg/standalone/service-worker/test/ServiceWorkerApp.test.ts

@@ -78,6 +78,17 @@ describe('standalone/service-worker/test/ServiceWorkerApp.test.ts', () => {
     assert.equal(res.headers.get('x-added'), '1');
   });
 
+  it('should return a Uint8Array body as bytes, not JSON', async () => {
+    const res = await fetch(`${base}/edge/bytes`);
+    assert.equal(await res.text(), 'byte-body');
+  });
+
+  it('should preserve multiple ctx.responseHeaders Set-Cookie on the merged response', async () => {
+    const res = await fetch(`${base}/edge/mw-cookies`);
+    assert.deepEqual(res.headers.getSetCookie(), ['x=1', 'y=2']);
+    assert.deepEqual(await res.json(), { ok: true });
+  });
+
   it('should run aop-mode middlewares (@Middleware with advice classes)', async () => {
     const res = await fetch(`${base}/aop-mw/aop`);
     assert.deepEqual(await res.json(), { body: { msg: 'hello' } });

tegg/standalone/service-worker/test/fixtures/hello-app/EdgeController.ts

@@ -24,4 +24,16 @@ export class EdgeController {
     ctx.responseHeaders.set('x-added', '1');
     return Response.redirect('http://localhost/dest', 302);
   }
+
+  @HTTPMethod({ method: HTTPMethodEnum.GET, path: '/bytes' })
+  async bytes() {
+    return new TextEncoder().encode('byte-body');
+  }
+
+  @HTTPMethod({ method: HTTPMethodEnum.GET, path: '/mw-cookies' })
+  async mwCookies(@InjectContext() ctx: any) {
+    ctx.responseHeaders.append('set-cookie', 'x=1');
+    ctx.responseHeaders.append('set-cookie', 'y=2');
+    return { ok: true };
+  }
 }

wiki/concepts/tegg-module-plugin.md

@@ -32,7 +32,7 @@ source_files:
   - tegg/plugin/controller/src/lib/impl/http/EggHTTPControllerRegistrar.ts
   - tegg/plugin/controller/src/lib/impl/mcp/EggMCPRegisterProvider.ts
   - tegg/standalone/service-worker-controller/src/http/FetchEventHandler.ts
-updated_at: 2026-07-13
+updated_at: 2026-07-14
 status: active
 ---
 

wiki/packages/service-worker.md

@@ -9,7 +9,7 @@ source_files:
   - tegg/core/controller-runtime/src
   - tegg/plugin/controller/src
   - examples/helloworld-service-worker
-updated_at: 2026-07-10
+updated_at: 2026-07-14
 status: active
 ---