Skip to content

Commit e785de1

Browse files
killaguclaude
andcommitted
revert(ci): un-shard egg-bin; keep single job (sharding broke fork isolation)
Splitting egg-bin by file made dev.test.ts / test.test.ts run in isolation, which broke fork-based tests that depend on cross-file shared state under isolate:false (e.g. dev --baseDir=root, test -h help) — green when the suite runs whole, red when split. Same isolation class as the tegg controller fix, but egg-bin has several such tests and fixing each would change test files. Revert to the original single egg-bin job (kept the windows HOME export). The job runs the whole egg-bin suite as before; it is not the binding wall constraint given macos/windows whole-suite jobs dominate total wall. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 950f1e7 commit e785de1

2 files changed

Lines changed: 6 additions & 68 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -263,16 +263,12 @@ jobs:
263263
matrix:
264264
os: ['ubuntu-latest', 'windows-latest']
265265
node: ['24']
266-
# dev.test.ts (~49s local) and test.test.ts (~42s) each spawn many
267-
# egg-bin CLI subprocesses; vitest --shard hashes both into one slice,
268-
# so split by explicit file groups to keep each ubuntu shard ≤60s.
269-
bin-shard: ['dev', 'test', 'rest']
270266

271-
name: Test bin (${{ matrix.os }}, ${{ matrix.node }}, ${{ matrix.bin-shard }})
267+
name: Test bin (${{ matrix.os }}, ${{ matrix.node }})
272268
runs-on: ${{ matrix.os }}
273269

274270
concurrency:
275-
group: test-egg-bin-${{ github.workflow }}-#${{ github.event.pull_request.number || github.head_ref || github.ref }}-(${{ matrix.os }}, ${{ matrix.node }}, ${{ matrix.bin-shard }})
271+
group: test-egg-bin-${{ github.workflow }}-#${{ github.event.pull_request.number || github.head_ref || github.ref }}-(${{ matrix.os }}, ${{ matrix.node }})
276272
cancel-in-progress: true
277273

278274
steps:
@@ -295,11 +291,10 @@ jobs:
295291
shell: pwsh
296292
run: echo "HOME=$env:USERPROFILE" >> $env:GITHUB_ENV
297293

298-
- name: Build egg-bin
299-
run: ut run build -- --workspace ./tools/egg-bin
300-
301-
- name: Run tests (bin shard ${{ matrix.bin-shard }})
302-
run: node scripts/run-egg-bin-shard.js ${{ matrix.bin-shard }}
294+
- name: Run tests
295+
run: |
296+
ut run build -- --workspace ./tools/egg-bin
297+
ut run ci --workspace @eggjs/bin
303298
304299
- name: Code Coverage
305300
# skip on windows, it will hangup on codecov https://github.com/codecov/codecov-action/issues/1787

scripts/run-egg-bin-shard.js

Lines changed: 0 additions & 57 deletions
This file was deleted.

0 commit comments

Comments
 (0)