fix(tegg-config): resolve framework module json packages locally

Author: gxkl

tegg/plugin/config/src/lib/ModuleScanner.ts

@@ -76,9 +76,12 @@ export class ModuleScanner {
     return frameworkDirs;
   }
 
-  private readAndDeduplicateModuleReferences(baseDir: string): readonly ModuleReference[] {
+  private readAndDeduplicateModuleReferences(baseDir: string, cwd?: string): readonly ModuleReference[] {
     return ModuleConfigUtil.deduplicateModules(
-      ModuleConfigUtil.readModuleReference(baseDir, this.readModuleOptions || {}),
+      ModuleConfigUtil.readModuleReference(baseDir, {
+        ...this.readModuleOptions,
+        ...(cwd ? { cwd } : {}),
+      }),
     );
   }
 
@@ -126,7 +129,7 @@ export class ModuleScanner {
     }
     debug('loadModuleReferences from frameworkDirs:%o', frameworkDirs);
     const optionalModuleReferences = frameworkDirs.flatMap((frameworkDir) =>
-      this.readAndDeduplicateModuleReferences(frameworkDir),
+      this.readAndDeduplicateModuleReferences(frameworkDir, frameworkDir),
     );
 
     // Merge all module references and deduplicate

tegg/plugin/config/test/ModuleScanner.test.ts

@@ -60,6 +60,20 @@ describe('plugin/config/test/ModuleScanner.test.ts', () => {
     expect(warnings).toEqual([]);
   });
 
+  it('should resolve framework module.json package references from the framework directory', () => {
+    const baseDir = getFixtures('framework-module-json/app');
+    const refs = new ModuleScanner(baseDir, { cwd: baseDir }).loadModuleReferences();
+
+    expect(refs).toEqual([
+      {
+        name: 'frameworkConfigModule',
+        package: 'framework-config-module',
+        path: path.join(baseDir, 'node_modules/chair-framework/node_modules/framework-config-module'),
+        optional: true,
+      },
+    ]);
+  });
+
   it('should stop scanning when framework chain has a cycle', () => {
     const baseDir = getFixtures('framework-cycle/app');
     const refs = new ModuleScanner(baseDir, {}).loadModuleReferences();

tegg/plugin/config/test/fixtures/framework-module-json/app/node_modules/chair-framework/config/module.json

@@ -0,0 +1,7 @@
+{
+  "name": "framework-module-json-app",
+  "type": "module",
+  "egg": {
+    "framework": "chair-framework"
+  }
+}

tegg/plugin/config/test/fixtures/framework-module-json/app/node_modules/chair-framework/node_modules/framework-config-module/package.json

@@ -35,6 +35,12 @@ describe('test/lib/EggModuleLoader.test.ts', () => {
         path: '/virtual/disabled-plugin',
         optional: true,
       },
+      {
+        name: 'samePathDifferentPackage',
+        package: 'module-package',
+        path: '/virtual/same-path',
+        optional: true,
+      },
     ];
     const app = {
       baseDir: '/virtual/app',
@@ -64,6 +70,11 @@ describe('test/lib/EggModuleLoader.test.ts', () => {
           package: 'disabled-plugin',
           path: '/virtual/disabled-plugin',
         },
+        samePathDifferentPackage: {
+          enable: true,
+          package: 'plugin-package',
+          path: '/virtual/same-path',
+        },
       },
     } as any;
 
@@ -79,6 +90,7 @@ describe('test/lib/EggModuleLoader.test.ts', () => {
     assert.equal(moduleReferences[0].optional, false);
     assert.equal(moduleReferences[1].optional, false);
     assert.equal(moduleReferences[2].optional, true);
+    assert.equal(moduleReferences[3].optional, true);
   });
 
   describe('has recursive dependency module', () => {