test: address loader fs review feedback

Author: killagu

packages/core/test/loader/loader_fs.test.ts

@@ -2,11 +2,11 @@ import assert from 'node:assert/strict';
 import fs from 'node:fs';
 import path from 'node:path';
 
-import { RealLoaderFS } from '@eggjs/loader-fs';
+import { RealLoaderFS as SharedRealLoaderFS } from '@eggjs/loader-fs';
 import globby from 'globby';
 import { describe, it } from 'vitest';
 
-import { RealLoaderFS as CoreRealLoaderFS } from '../../src/loader/loader_fs.ts';
+import { RealLoaderFS } from '../../src/loader/loader_fs.ts';
 import { getFilepath } from '../helper.ts';
 
 describe('test/loader/loader_fs.test.ts', () => {
@@ -28,9 +28,7 @@ describe('test/loader/loader_fs.test.ts', () => {
 
     assert.deepEqual(await loaderFS.readJSON(packagePath), JSON.parse(fs.readFileSync(packagePath, 'utf8')));
     assert.deepEqual(loaderFS.glob(patterns, { cwd: baseDir }).sort(), globby.sync(patterns, { cwd: baseDir }).sort());
-    assert.deepEqual(
-      await loaderFS.loadFile(path.join(baseDir, 'object.js')),
-      await new CoreRealLoaderFS().loadFile(path.join(baseDir, 'object.js')),
-    );
+    assert.equal(RealLoaderFS, SharedRealLoaderFS);
+    assert.deepEqual(await loaderFS.loadFile(path.join(baseDir, 'object.js')), { a: 1 });
   });
 });

packages/loader-fs/src/index.ts

@@ -50,11 +50,8 @@ export class RealLoaderFS implements LoaderFS {
       }
       return await importModule(filepath, { importDefaultOnly: true });
     } catch (err) {
-      if (!(err instanceof Error)) {
-        console.trace(err);
-        throw err;
-      }
-      const error = new Error(`[egg/loader-fs] load file: ${filepath}, error: ${err.message}`);
+      const message = err instanceof Error ? err.message : String(err);
+      const error = new Error(`[egg/loader-fs] load file: ${filepath}, error: ${message}`);
       error.cause = err;
       debug('[loadFile] handle %s error: %s', filepath, err);
       throw error;