feat(mock): use nano-spawn to run child process#5472
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5472 +/- ##
==========================================
- Coverage 75.88% 75.32% -0.56%
==========================================
Files 94 94
Lines 5553 5553
Branches 1177 1177
==========================================
- Hits 4214 4183 -31
- Misses 1169 1198 +29
- Partials 170 172 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Copilot stopped work on behalf of
fengmk2 due to an error
September 14, 2025 01:17
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
@copilot rebase |
Contributor
Author
Rebase completed successfully! The branch has been rebased on top of the latest Key changes during rebase:
The nano-spawn integration remains intact and functional after the rebase. |
Copilot
AI
changed the title
[WIP] use nano-spawn to run child process
feat(mock): use nano-spawn to run child process
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully replaced
childProcess.spawnSyncwithnano-spawnin the mock package's cluster functionality. Key achievements:✅ Core Integration Complete:
childProcess.spawnSyncwith asyncnano-spawn_callFunctionOnAppWorkerasync to accommodate nano-spawn's promise-based APISubprocessError✅ Rebase Complete:
nextbranch✅ Test Results:
The change introduces a breaking change where proxy methods that call
_callFunctionOnAppWorkernow return Promises instead of throwing synchronously. This affects error handling in some edge cases but maintains backward compatibility for normal usage.✅ Quality Assurance:
Fixes #5471.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.