Skip to content

chore: remove pnpm-lock.yaml to verify unlocked deps #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 13 commits into from
Apr 7, 2026
Merged

chore: remove pnpm-lock.yaml to verify unlocked deps #5859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3d2a518
chore: remove pnpm-lock.yaml and use --no-frozen-lockfile
elrrrrrrr Apr 3, 2026
9b68196
fix(ci): remove cache: pnpm since there is no lockfile
elrrrrrrr Apr 3, 2026
36f6b50
fix: resolve three issues exposed by unlocked dependency versions
elrrrrrrr Apr 3, 2026
c334f39
fix: remove dedupe check and update snapshots for new typebox exports
elrrrrrrr Apr 3, 2026
cdb3767
fix(test): add Match and TakeLeft to typebox ExtendsResult snapshots
elrrrrrrr Apr 3, 2026
6c216a0
chore: remove accidentally committed pnpm-lock.yaml
elrrrrrrr Apr 3, 2026
568e6c3
fix(test): replace typebox full-snapshot with targeted export assertions
elrrrrrrr Apr 3, 2026
0cd8ad5
fix(test): remove Ajv assertion (interface, not runtime value)
elrrrrrrr Apr 3, 2026
4c91093
fix(common-util): skip oxc-project/runtime helper in vite virtual mod…
elrrrrrrr Apr 7, 2026
719a9af
fix(test): restructure ORM test for Vitest 4 compatibility
elrrrrrrr Apr 7, 2026
5f30132
fix(test): loosen tsc error regex to match new oxc parser format
elrrrrrrr Apr 7, 2026
9d7fb61
fix(test): correct vitest alias paths to src/index.ts for tegg-vitest
elrrrrrrr Apr 7, 2026
c4ae9ea
fix(ci): apply lockfile-less changes to release.yml and clean up giti…
elrrrrrrr Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,13 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
with:
node-version: '24'
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile
Comment thread
elrrrrrrr marked this conversation as resolved.

- name: Run lint
run: pnpm run lint

- name: Check dedupe
run: pnpm dedupe --check

- name: Run typecheck
run: pnpm run typecheck
Comment on lines 41 to 45
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description lists only lockfile removal and switching CI installs to --no-frozen-lockfile, but this workflow change also removes the pnpm dedupe --check step. If this is intentional, please update the PR description; otherwise consider re-adding the dedupe check to keep the existing CI guardrail.

Copilot uses AI. Check for mistakes.

Expand Down Expand Up @@ -161,10 +157,9 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
with:
node-version: ${{ matrix.node }}
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile

- name: Run tests
run: pnpm run ci
Expand Down Expand Up @@ -206,10 +201,9 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
with:
node-version: ${{ matrix.node }}
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile

- name: Run tests
run: |
Expand Down Expand Up @@ -248,10 +242,9 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
with:
node-version: ${{ matrix.node }}
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile

- name: Run tests
run: |
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,9 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
with:
node-version: ${{ matrix.project.node-version }}
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile

- name: Build all packages
run: pnpm build
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,10 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
with:
node-version: '24'
cache: 'pnpm'
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pnpm install --no-frozen-lockfile in the release workflow makes the release build non-reproducible (dependency graph can change between runs without any git changes), which increases the risk of publishing broken or unverifiable artifacts. Consider keeping releases deterministic (e.g., commit a lockfile and use --frozen-lockfile at least for release.yml), while running the unlocked-deps experiment in a separate CI workflow.

Suggested change
run: pnpm install --no-frozen-lockfile
run: pnpm install --frozen-lockfile

Copilot uses AI. Check for mistakes.

- name: Configure Git
run: |
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ package-lock.json
.tshy*
dist
site/.dumi/
!pnpm-lock.yaml

!packages/egg/test/fixtures/apps/loader-plugin/node_modules
!packages/egg/test/fixtures/apps/app-ts/node_modules
Expand Down Expand Up @@ -117,4 +116,5 @@ tegg/plugin/tegg/test/fixtures/apps/**/*.js
*.tgz

ecosystem-ci/cnpmcore
ecosystem-ci/examples
ecosystem-ci/examples
pnpm-lock.yaml
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
"tsdown": "catalog:",
"tsx": "catalog:",
"typescript": "catalog:",
"unplugin-unused": "catalog:",
Comment thread
elrrrrrrr marked this conversation as resolved.
"urllib": "catalog:",
"vitest": "catalog:"
Comment thread
elrrrrrrr marked this conversation as resolved.
},
Expand Down
Loading
Loading