Skip to content

perf(ci): persist V8 compile cache across test jobs #6008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
killagu wants to merge 1 commit into from
+45 −0
Closed

perf(ci): persist V8 compile cache across test jobs #6008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ jobs:
name: Test (${{ matrix.os }}, ${{ matrix.node }})
runs-on: ${{ matrix.os }}

env:
# Persisted V8 compile cache (restored/saved by the "Cache Node compile
# cache" step). Set at job level so vitest workers and any forked child
# processes inherit NODE_COMPILE_CACHE.
NODE_COMPILE_CACHE: ${{ runner.temp }}/node-compile-cache

Comment on lines +89 to +94

@coderabbitai coderabbitai Bot Jun 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

runner.temp isn't available in jobs.<job>.env.
Use ${{ github.workspace }} here, or move this to step-level env, and apply the same fix to the other two job-level blocks.

🧰 Tools
🪛 actionlint (1.7.12)

[error] 93-93: context "runner" is not allowed here. available contexts are "github", "inputs", "matrix", "needs", "secrets", "strategy", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details

(expression)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 89 - 94, runner.temp is not valid in
jobs.<job>.env, so update the job-level NODE_COMPILE_CACHE definition in the CI
workflow to use github.workspace or move it into step-level env instead. Make
the same adjustment in the other two job-level env blocks that currently
reference runner.temp, and keep the change aligned with the existing cache setup
around NODE_COMPILE_CACHE.

concurrency:
group: test-${{ github.workflow }}-#${{ github.event.pull_request.number || github.head_ref || github.ref }}-(${{ matrix.os }}, ${{ matrix.node }})
cancel-in-progress: true
Expand Down Expand Up @@ -181,6 +187,15 @@ jobs:
with:
node-version: ${{ matrix.node }}

- name: Cache Node compile cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ${{ runner.temp }}/node-compile-cache
key: node-compile-cache-${{ runner.os }}-node${{ matrix.node }}-${{ hashFiles('pnpm-workspace.yaml', '**/package.json') }}
restore-keys: |
node-compile-cache-${{ runner.os }}-node${{ matrix.node }}-
node-compile-cache-${{ runner.os }}-

- name: Cache utoo package store
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
Expand Down Expand Up @@ -244,6 +259,12 @@ jobs:
name: Test bin (${{ matrix.os }}, ${{ matrix.node }})
runs-on: ${{ matrix.os }}

env:
# Persisted V8 compile cache (restored/saved by the "Cache Node compile
# cache" step). Set at job level so vitest workers and any forked child
# processes inherit NODE_COMPILE_CACHE.
NODE_COMPILE_CACHE: ${{ runner.temp }}/node-compile-cache

concurrency:
group: test-egg-bin-${{ github.workflow }}-#${{ github.event.pull_request.number || github.head_ref || github.ref }}-(${{ matrix.os }}, ${{ matrix.node }})
cancel-in-progress: true
Expand All @@ -260,6 +281,15 @@ jobs:
with:
node-version: ${{ matrix.node }}

- name: Cache Node compile cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ${{ runner.temp }}/node-compile-cache
key: node-compile-cache-${{ runner.os }}-node${{ matrix.node }}-${{ hashFiles('pnpm-workspace.yaml', '**/package.json') }}
restore-keys: |
node-compile-cache-${{ runner.os }}-node${{ matrix.node }}-
node-compile-cache-${{ runner.os }}-

- name: Cache utoo package store
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
Expand Down Expand Up @@ -310,6 +340,12 @@ jobs:
name: Test scripts (${{ matrix.os }}, ${{ matrix.node }})
runs-on: ${{ matrix.os }}

env:
# Persisted V8 compile cache (restored/saved by the "Cache Node compile
# cache" step). Set at job level so vitest workers and any forked child
# processes inherit NODE_COMPILE_CACHE.
NODE_COMPILE_CACHE: ${{ runner.temp }}/node-compile-cache

concurrency:
group: test-egg-scripts-${{ github.workflow }}-#${{ github.event.pull_request.number || github.head_ref || github.ref }}-(${{ matrix.os }}, ${{ matrix.node }})
cancel-in-progress: true
Expand All @@ -326,6 +362,15 @@ jobs:
with:
node-version: ${{ matrix.node }}

- name: Cache Node compile cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ${{ runner.temp }}/node-compile-cache
key: node-compile-cache-${{ runner.os }}-node${{ matrix.node }}-${{ hashFiles('pnpm-workspace.yaml', '**/package.json') }}
restore-keys: |
node-compile-cache-${{ runner.os }}-node${{ matrix.node }}-
node-compile-cache-${{ runner.os }}-

- name: Cache utoo package store
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
Expand Down
Loading