[codex] Add eggcc proof baseline helpers#56
Closed
saulshanabrook wants to merge 4 commits into
Closed
Conversation
ff86265 to
6b37b6b
Compare
Member
Author
|
Closing in favor of saulshanabrook/egglog-encoding#8 for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the eggcc proof baseline onto a new egglog core branch made from current egglog
mainmerged with egglog PR #927:egraphs-good/egglog, branchcodex/pr927-main-exp56-refreshd69df09a74800b68a727b2c39b1e5cca31042b3emain7e926c6e2842db66c3f40e5cb6139a6406a9d05a+ PR #9279a37d278337f0b557a3d27fd4b7a729a8a1bf2d2Changes in this PR:
egglog,egglog-ast, andegglog-reportsat the refreshed core branch.keep-best,print-table-stats, and dynamicset-costextraction from the removedFunctionRow/function_for_each/lookup_function/with_full_stateAPIs to the currentfunction_entries,constructor_enodes,read, andupdateAPIs.keep-bestandprint-table-statsby falling back from function-entry scans/writes to constructor enode scans/adds.tests/fixtures/eggcc-2mm-pass1-merge-old.eggwith former:no-mergefunctions represented as:merge old.Validation
Core, in
/Users/saul/p/wt/egg-smol/pr927-main-exp56-refresh:Experimental, in
/Users/saul/p/wt/egglog-experimental/eggcc-proof-baseline-pr927-refresh-worker:Results: all commands passed.
integration_testpassed 39/39.eggcc_2mm_proofpassed the checked-in fixture/static test; the full proof canary remains ignored in the test harness.Release Timings
Timed in
/Users/saul/p/wt/egglog-experimental/eggcc-proof-baseline-pr927-refresh-workerwith the release binary and the checked-in fixture./usr/bin/time -l target/release/egglog-experimental tests/fixtures/eggcc-2mm-pass1-merge-old.egg/usr/bin/time -l target/release/egglog-experimental --proofs tests/fixtures/eggcc-2mm-pass1-merge-old.egg(check ...)or(prove ...)forms, so this exercises proof-mode instrumentation/generation but does not print a proof-testing result. It emits proof-normal-form warnings for non-top-level function calls in query facts.Downstream users can depend on the refreshed core branch with: