Add back_off scheduler#350
Merged
Merged
Conversation
Adds supports for the back off scheduler from experimental, and builds out mechanism in general to run custom schedulers.
Member
Author
|
@actions-user changelog |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the back_off scheduler from experimental, and builds out a general mechanism to run custom schedulers. The change enables users to create custom backoff schedulers with configurable parameters and use them in their egglog schedules.
- Adds
BackOffclass andback_off()function for creating backoff schedulers - Updates
run()function to accept an optionalschedulerparameter - Implements automatic scheduler hoisting and scoping mechanisms
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| python/egglog/declarations.py | Adds BackOffDecl, LetSchedulerDecl types and updates RunDecl to support schedulers |
| python/egglog/egraph.py | Adds BackOff class, back_off() function, and updates run() to accept scheduler parameter |
| python/egglog/egraph_state.py | Implements scheduler processing logic and conversion to egg commands |
| python/egglog/pretty.py | Updates pretty printing to handle new scheduler declarations |
| python/tests/test_high_level.py | Adds comprehensive test cases for scheduler functionality |
| python/tests/test_pretty.py | Adds test cases for scheduler pretty printing |
| docs/reference/egglog-translation.md | Documents the new scheduler feature with examples |
| python/egglog/examples/jointree.py | Removes trailing empty lines |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #350 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds supports for the back off scheduler from experimental, and builds out mechanism in general to run custom schedulers.