Custom UF-backed tables in the egglog language.#782
Draft
ezrosent wants to merge 6 commits into
Draft
Conversation
ezrosent
commented
Jan 6, 2026
| }) | ||
| .map_err(|err| Error::BackendError(err.to_string()))?; | ||
|
|
||
| match canon_prim { |
Contributor
Author
There was a problem hiding this comment.
Can probably clean this up a bit.
CodSpeed Performance ReportMerging #782 will not alter performanceComparing Summary
Footnotes
|
Member
|
This looks great, I'll try it out with my branch before I give a serious review |
oflatt
added a commit
to oflatt/egglog-duckdb
that referenced
this pull request
Jun 20, 2026
… UF baselines Follow-on to the file_supports_proofs gate fix (2d673da), which made several files newly proof-eligible. Two have latent proof issues unrelated to the global fix, so skip their proof trials (mirrors math-microbenchmark): - repro-unsound.egg OOMs under --proofs/--proof-testing. - web-demo/math.egg's desugar_proof_testing hits a pre-existing proof-extraction bug ("Fiat proof claims N = M, not established by globals"); its --proofs/--proof-testing variants also time out. math.egg's globals are eq-sort (the unchanged constructor path), so this is NOT from Blocker 1's non-eq-sort code -- tracked as a follow-up. Added to both proof_unsupported_file_list and duckdb_proofs_too_slow; ends_with is component-based, so integer_math.egg keeps full proof coverage and math-microbenchmark keeps its _proofs_duckdb coverage. Also accept 2 stray snapshot baselines the gate fix surfaced as correct: - files__fail-typecheck__uf_onchange_schema.snap (correct native-UF schema error) - files__shared_snapshot_uf_function.snap (uf_function correct tuple counts) Pre-existing + separate (not addressed here): fail-typecheck/uf_schema(+_32threads) still fails -- PR egraphs-good#782 native-UF schema validation not firing; no baseline accepted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll use this in the term encoding. Opening as a draft for now.