Skip to content

Better subset representation with BitSet#847

Open
yihozhang wants to merge 5 commits into
reuse-indicesfrom
better-subset
Open

Better subset representation with BitSet#847
yihozhang wants to merge 5 commits into
reuse-indicesfrom
better-subset

Conversation

@yihozhang

Copy link
Copy Markdown
Collaborator

No description provided.

@yihozhang yihozhang requested a review from a team as a code owner April 14, 2026 05:10
@yihozhang yihozhang requested review from FTRobbin and removed request for a team April 14, 2026 05:10
@codspeed-hq

codspeed-hq Bot commented Apr 14, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.22%

❌ 1 regressed benchmark
✅ 45 untouched benchmarks
⏩ 190 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime rust_rule_match_overhead[rule_run_1] 14 ms 14.8 ms -5.22%

Comparing better-subset (7aeb1f6) with reuse-indices (8fb58d2)

Open in CodSpeed

Footnotes

  1. 190 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.58657% with 291 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.02%. Comparing base (9345f32) to head (7aeb1f6).
⚠️ Report is 3 commits behind head on reuse-indices.

Files with missing lines Patch % Lines
core-relations/src/offsets/mod.rs 15.43% 274 Missing ⚠️
core-relations/src/free_join/execute.rs 92.98% 16 Missing ⚠️
core-relations/src/free_join/frame_update.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           reuse-indices     #847      +/-   ##
=================================================
- Coverage          86.89%   86.02%   -0.87%     
=================================================
  Files                 85       85              
  Lines              24340    24750     +410     
=================================================
+ Hits               21151    21292     +141     
- Misses              3189     3458     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yihozhang yihozhang force-pushed the reuse-indices branch 2 times, most recently from e556986 to 8a54f1f Compare April 30, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants