Add primitive body typecheck helpers#881
Conversation
Merging this PR will improve performance by 27.82%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 🆕 | Simulation | tests[repro-herbie-vanilla] |
N/A | 1.4 s | N/A |
| ❌ | Simulation | tests[python_array_optimize] |
1.5 s | 1.6 s | -6.94% |
| ⚡ | Simulation | rust_rule_fib[rule_run_1000] |
280.7 ms | 202.7 ms | +38.46% |
| ⚡ | Simulation | tests[cykjson] |
440.2 ms | 271.6 ms | +62.08% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing saulshanabrook:codex/split-primitive-body-runtime-apis (f8883c7) with main (8c1c70b)2
Footnotes
-
215 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(36de434) during the generation of this report, so 8c1c70b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
f5db02d to
22481a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 87.06% 86.99% -0.08%
==========================================
Files 88 88
Lines 25844 26064 +220
==========================================
+ Hits 22502 22675 +173
- Misses 3342 3389 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
22481a2 to
2fbd1d1
Compare
Context
This is the egglog-side support needed by egglog-experimental's body-defined
(primitive ...)command. It intentionally contains only the reusable API surface and not the experimental command implementation.Companion experimental PR: egraphs-good/egglog-experimental#46.
Changes
EGraph.SpecializedPrimitive::applyfor evaluating an already-specialized primitive against runtime values.Validation
cargo test --lib typecheck_expr_with_outputcargo fmtgit diff --check