Skip to content

Restore full paths in span errors#886

Open
saulshanabrook wants to merge 4 commits into
egraphs-good:mainfrom
saulshanabrook:codex/split-span-full-path-errors
Open

Restore full paths in span errors#886
saulshanabrook wants to merge 4 commits into
egraphs-good:mainfrom
saulshanabrook:codex/split-span-full-path-errors

Conversation

@saulshanabrook
Copy link
Copy Markdown
Member

@saulshanabrook saulshanabrook commented May 18, 2026

Context

Span display was truncating paths to file names, which loses useful context when callers pass meaningful source paths.

Changes

  • Preserves full caller-provided paths in Span display.
  • Keeps file-test snapshots stable by passing file-name-only labels for fail-typecheck snapshot runs.
  • Adds a span display regression test.

Validation

  • cargo test -p egglog-ast egglog_span_display_preserves_full_path
  • cargo test --test files arity_mismatch
  • cargo fmt
  • git diff --check

@saulshanabrook saulshanabrook marked this pull request as ready for review May 18, 2026 20:24
@saulshanabrook saulshanabrook requested a review from a team as a code owner May 18, 2026 20:24
@saulshanabrook saulshanabrook requested review from ezrosent and removed request for a team May 18, 2026 20:24
@saulshanabrook saulshanabrook force-pushed the codex/split-span-full-path-errors branch from 22447f7 to d84a96a Compare May 18, 2026 20:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.08%. Comparing base (e564e46) to head (90f111f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files          88       88           
  Lines       25867    25873    +6     
=======================================
+ Hits        22526    22532    +6     
  Misses       3341     3341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 18, 2026

Merging this PR will improve performance by 27.39%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 22 untouched benchmarks
🆕 1 new benchmark
⏩ 215 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation tests[python_array_optimize] 1.5 s 1.7 s -8.09%
🆕 Simulation tests[repro-herbie-vanilla] N/A 1.4 s N/A
Simulation rust_rule_fib[rule_run_1000] 280.7 ms 202.8 ms +38.39%
Simulation tests[cykjson] 440.2 ms 270.8 ms +62.53%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing saulshanabrook:codex/split-span-full-path-errors (90f111f) with main (8c1c70b)2

Open in CodSpeed

Footnotes

  1. 215 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (e564e46) during the generation of this report, so 8c1c70b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@saulshanabrook saulshanabrook force-pushed the codex/split-span-full-path-errors branch from d84a96a to 0ffa59e Compare May 20, 2026 18:59
@saulshanabrook saulshanabrook requested review from yihozhang and removed request for ezrosent May 25, 2026 22:19
@saulshanabrook saulshanabrook moved this to This Week in Saul Shanabrook May 26, 2026
@saulshanabrook saulshanabrook moved this from This Week to Waiting for Review in Saul Shanabrook May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants