Restore full paths in span errors#886
Conversation
22447f7 to
d84a96a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 88 88
Lines 25867 25873 +6
=======================================
+ Hits 22526 22532 +6
Misses 3341 3341 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 27.39%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | tests[python_array_optimize] |
1.5 s | 1.7 s | -8.09% |
| 🆕 | Simulation | tests[repro-herbie-vanilla] |
N/A | 1.4 s | N/A |
| ⚡ | Simulation | rust_rule_fib[rule_run_1000] |
280.7 ms | 202.8 ms | +38.39% |
| ⚡ | Simulation | tests[cykjson] |
440.2 ms | 270.8 ms | +62.53% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing saulshanabrook:codex/split-span-full-path-errors (90f111f) with main (8c1c70b)2
Footnotes
-
215 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(e564e46) during the generation of this report, so 8c1c70b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
d84a96a to
0ffa59e
Compare
Context
Span display was truncating paths to file names, which loses useful context when callers pass meaningful source paths.
Changes
Spandisplay.Validation
cargo test -p egglog-ast egglog_span_display_preserves_full_pathcargo test --test files arity_mismatchcargo fmtgit diff --check