Allow hidden proof RHS lookups without forcing naive rules#931
Allow hidden proof RHS lookups without forcing naive rules#931saulshanabrook wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 89 89
Lines 26804 26810 +6
=======================================
+ Hits 23197 23203 +6
Misses 3607 3607 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Closing as superseded by #912. I verified the downstream stack without this PR: container PR #927 merged with current main (including #912), plus the container follow-up, #928, #929, and #930, with no #931/internal_hidden changes. egglog-experimental and eggcc both built, the regenerated eggcc 2mm export was byte-identical to the prior export, and completed in real 15.56s. |
|
Correction to the close comment: the verified command was |
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
FunctionDecl.internal_hiddenontoFuncTypeso generated proof/term-encoding functions keep their hidden metadata after typechecking.Motivation
This is the mainline RHS lookup/typechecking slice motivated by eggcc proof-mode performance. In coordinator verification on 2026-06-24, forcing generated proof-action rules with RHS proof lookups to
:naivemade the eggcc 2mm proof-mode export run for about 589s before manual termination. Preserving seminaive execution on the composed stack completed the same 2mm proof run in about 18s.This branch contains only the RHS lookup/typechecking slice. It does not include the container PR work, PR #930 changes, set validators, Maybe/Either support, eggcc changes, or experimental changes.
Tests
cargo test -p egglog proofs::proof_tests::tests -- --nocapturecargo fmt --checkgit diff --checkcargo test -p egglog --test files calc_proofscargo test -p egglog --test files fail-typecheck/looking_up_nonconstructor_in_action_case_set