v3.4.0: port uvarpro figures (gg_beta_uvarpro + gg_sdependent) to the V3 CRAN line#130
Merged
Conversation
Brings the two uvarpro visualization wrappers (varPro::get.beta.entropy bar chart; varPro::sdependent signal-variable lollipop) from the dev_rhf line down to a V3 3.4.0 minor, per the V3=varPro / V4=randomForestRHF boundary. New files only; no new dependency (varPro already in Imports). Tests carry skip_on_cran for the uvarpro-grow gcc-UBSAN issue. Version 3.3.0 -> 3.4.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ction (3.4.0) Two subsections after gg_udependent, run live on the cached u_boston fit (consistent with how gg_udependent is shown): the entropy-ranking bar chart and the signal-variable lollipop. No precompute change (both are post-fit processors on the existing uvarpro fit, like get.beta.entropy/sdependent already used by gg_udependent in the vignette). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 87.45% 88.06% +0.60%
==========================================
Files 44 48 +4
Lines 4090 4356 +266
==========================================
+ Hits 3577 3836 +259
- Misses 513 520 +7
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Ports the unsupervised uvarpro visualization wrappers into the V3/CRAN line, adding tidy data wrappers plus plot/print/summary/autoplot companions for entropy-based importance and signal-variable detection from varPro::uvarpro() fits.
Changes:
- Added new exported wrappers
gg_beta_uvarpro()andgg_sdependent()with corresponding S3plot,print,summary, andautoplotmethods. - Added test coverage for both wrappers (including a CRAN-skipped live integration check).
- Updated documentation and site/vignette surfaces (Rd pages, vignette sections, pkgdown reference), and bumped version to 3.4.0.
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
R/gg_beta_uvarpro.R |
New tidy wrapper around varPro::get.beta.entropy() including print/summary/autoplot and validation helpers. |
R/plot.gg_beta_uvarpro.R |
New bar-chart plot method for gg_beta_uvarpro. |
R/gg_sdependent.R |
New tidy wrapper around varPro::sdependent() including print/summary/autoplot. |
R/plot.gg_sdependent.R |
New lollipop plot method for gg_sdependent. |
tests/testthat/test_gg_beta_uvarpro.R |
Unit tests for shape/ranking/cutoff/provenance + CRAN-skipped live integration. |
tests/testthat/test_gg_sdependent.R |
Unit tests for shape/ranking/signal flag/provenance + CRAN-skipped live integration. |
vignettes/varpro.qmd |
Adds vignette sections demonstrating both new wrappers. |
man/gg_beta_uvarpro.Rd |
New Rd page for gg_beta_uvarpro(). |
man/plot.gg_beta_uvarpro.Rd |
New Rd page for plot.gg_beta_uvarpro(). |
man/gg_sdependent.Rd |
New Rd page for gg_sdependent(). |
man/plot.gg_sdependent.Rd |
New Rd page for plot.gg_sdependent(). |
man/print.gg.Rd |
Regenerated to include the new print methods. |
man/summary.gg.Rd |
Regenerated to include the new summary methods. |
NAMESPACE |
Registers new S3 methods / exports and ggplot2 import for geom_segment. |
_pkgdown.yml |
Adds the new topics to the pkgdown reference index. |
NEWS.md |
Adds the v3.4.0 release notes for the new wrappers. |
DESCRIPTION |
Bumps version from 3.3.0 to 3.4.0. |
Files not reviewed (6)
- man/gg_beta_uvarpro.Rd: Generated file
- man/gg_sdependent.Rd: Generated file
- man/plot.gg_beta_uvarpro.Rd: Generated file
- man/plot.gg_sdependent.Rd: Generated file
- man/print.gg.Rd: Generated file
- man/summary.gg.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the two uvarpro visualization wrappers from the
dev_rhfline down to a V3 3.4.0 CRAN minor, per the V3 = varPro / V4 = randomForestRHF boundary (recorded in the branch-strategy memory). Both wrapvarPro::only — norandomForestRHFdependency.gg_beta_uvarpro()/plot— entropy-ranking bar chart fromvarPro::get.beta.entropy(); the unsupervised analogue ofgg_beta_varpro().print/summary/autoplotcompanions.gg_sdependent()/plot— signal-variable lollipop fromvarPro::sdependent(); complementsgg_udependent()(structure) with a signal-vs-noise ranking.What's in the port
dev_rhf; print/summary/autoplot are self-contained in thegg_*.Rfiles.man/(4 pages) + NAMESPACE regenerated.varProalready in Imports).skip_on_cranfor the upstream uvarpro-grow gcc-UBSAN issue._pkgdown.ymlentries added.u_bostonfit (same treatment asgg_udependent).3.3.0 → 3.4.0.Verification
R CMD check --as-cranwith manual: clean (only env NOTEs — days-since-update, local HTML-tidy); vignette rebuilds with the new chunks; ~3.5 minNote on
dev_rhfdev_rhfalready has these files (PR #121). After 3.4.0 is accepted, themain→dev_rhfforward-merge reconciles them to V3's version (takemain's side if diverged).🤖 Generated with Claude Code