Refactor loop indices to use seq_along for improved readability and p…#61
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 23 23
Lines 1805 1805
=======================================
Hits 1503 1503
Misses 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ty categorical lists
…andling of categorical data
…istent binding and ensure proper factor levels in categorical data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to the codebase by replacing instances of
seq_len(length(...))withseq_along(...)for iterating over indices. This change improves code clarity and robustness by using a more idiomatic approach for indexing.Most important changes:
Code quality improvements:
seq_len(length(gg_dta))withseq_along(gg_dta)in theplot.gg_rocfunction inR/plot.gg_roc.Rto iterate over the elements more safely and idiomatically.tests/testthat/test_gg_variable.Rto useseq_along()instead ofseq_len(length(...))for both classification and regression test cases, ensuring consistency and reducing potential indexing errors. [1] [2]…erformance