Show successful TCP ports next to verify stage results#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
verifyCLI output did not make it easy to see which tested TCP ports succeeded, forcing users to inspect the full report JSON to discover working ports.Description
portandprotocolmetadata to the L4 (tcp-443) and L5 (tcp-80) checks by updatingsrc/checks/l4_tcp_443.jsandsrc/checks/l5_tcp_80.jsso pipeline levels include port information.🧪 STAGE RESULTSpanel in theverifycommand insidecli.jsto show each stage asPASS/FAIL.(port <n> ✅)and include an aggregatedSuccessful portsline in the verify summary panel.Testing
npm test, all tests passed (6tests,0failures).node cli.js verify 1.1.1.1 -t 1to validate CLI output, which showed the new🧪 STAGE RESULTSpanel and theSuccessful portssummary as expected.Codex Task