root: patch for tessellated closure checks after initialization#948
Conversation
There was a problem hiding this comment.
Pull request overview
This PR backports a ROOT geometry fix to address failures when using tessellated solids (closure checks after initialization), targeting ROOT 6.40.00 in the Spack overlay.
Changes:
- Add a conditional patch for ROOT
@6.40.00that applies the upstream commitd443536...(tessellated closure checks fix).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ruse-traveler
left a comment
There was a problem hiding this comment.
Looks good! Though I'm seeing a weird error about "returned 503: egress is over the limit" in the Build and Test Packages check....
I've seen this once before, and created #921 to avoid it being an error since it's just a metadata update and not that important. |
Gotcha! In that case this is ready to go! |
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR backports root-project/root#22457 to ROOT 6.40.00 to fix our use of tessellated solids in the BHCal (https://github.com/eic/containers/actions/runs/26316798957/job/77483990403?pr=298).
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply