Skip to content

root: patch for tessellated closure checks after initialization#948

Merged
wdconinc merged 4 commits into
developfrom
root-pr22457
Jun 5, 2026
Merged

root: patch for tessellated closure checks after initialization#948
wdconinc merged 4 commits into
developfrom
root-pr22457

Conversation

@wdconinc

@wdconinc wdconinc commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR backports root-project/root#22457 to ROOT 6.40.00 to fix our use of tessellated solids in the BHCal (https://github.com/eic/containers/actions/runs/26316798957/job/77483990403?pr=298).

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI review requested due to automatic review settings June 2, 2026 15:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports a ROOT geometry fix to address failures when using tessellated solids (closure checks after initialization), targeting ROOT 6.40.00 in the Spack overlay.

Changes:

  • Add a conditional patch for ROOT @6.40.00 that applies the upstream commit d443536... (tessellated closure checks fix).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc mentioned this pull request Jun 2, 2026
12 tasks
@wdconinc wdconinc enabled auto-merge (squash) June 3, 2026 12:48

@ruse-traveler ruse-traveler left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though I'm seeing a weird error about "returned 503: egress is over the limit" in the Build and Test Packages check....

@wdconinc

wdconinc commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Looks good! Though I'm seeing a weird error about "returned 503: egress is over the limit" in the Build and Test Packages check....

I've seen this once before, and created #921 to avoid it being an error since it's just a metadata update and not that important.

@ruse-traveler

Copy link
Copy Markdown

I've seen this once before, and created #921 to avoid it being an error since it's just a metadata update and not that important.

Gotcha! In that case this is ready to go!

@wdconinc wdconinc merged commit b219d99 into develop Jun 5, 2026
9 of 10 checks passed
@wdconinc wdconinc deleted the root-pr22457 branch June 5, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants