fix(ci): run npsim with --random.enableEventSeed - #79
Merged
Conversation
wdconinc
changed the title
--random.enableEventSeed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions CI workflow to make npsim runs more reproducible by enabling per-event seeding in addition to setting a fixed global RNG seed.
Changes:
- Add
--random.enableEventSeedto the gun-basednpsimCI run. - Add
--random.enableEventSeedto the DIS-inputnpsimCI run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
enabled auto-merge (squash)
July 2, 2026 19:53
wdconinc
moved this to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
Capybara summary for PR 79
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR adds
--random.enableEventSeedto the npsim CI tests to ensure we end up simulating the same events even when the internal event random number consumption changes. Mostly aspirational until we pick up AIDASoft/DD4hep#1617 (at least for gun)...What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply