tests: fix and refactor tests (#1262)

Co-authored-by: bytecii <bytecii@users.noreply.github.com>
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com>

Author: bytecii

.github/workflows/pre-commit.yml

@@ -30,34 +30,6 @@ jobs:
         run: uv sync --group dev
 
       - name: Run pre-commit
-        run: |
-          uv run pre-commit run --files \
-            $(find \
-              app/agent \
-              app/controller \
-              app/exception \
-              app/middleware \
-              app/model \
-              app/service \
-              benchmark \
-              tests/app \
-              -type f ! -path '*__pycache__*') \
-            app/__init__.py \
-            app/router.py \
-            app/component/__init__.py \
-            app/component/pydantic/__init__.py \
-            app/utils/listen/__init__.py \
-            app/utils/server/__init__.py \
-            app/utils/toolkit/__init__.py \
-            app/utils/toolkit/google_calendar_toolkit.py \
-            app/utils/toolkit/google_gmail_mcp_toolkit.py \
-            app/utils/toolkit/linkedin_toolkit.py \
-            app/utils/toolkit/reddit_toolkit.py \
-            app/utils/toolkit/slack_toolkit.py \
-            app/utils/toolkit/twitter_toolkit.py \
-            app/utils/toolkit/whatsapp_toolkit.py \
-            app/utils/workforce.py \
-            app/utils/single_agent_worker.py \
-            tests/conftest.py
+        run: uv run pre-commit run --files $(git ls-files .)
         env:
           SKIP: no-commit-to-branch

backend/app/utils/telemetry/workforce_metrics.py

@@ -168,20 +168,18 @@ def initialize_tracer_provider() -> None:
     _GLOBAL_TRACER_PROVIDER = provider
 
 
-def get_tracer_provider() -> TracerProvider:
+def get_tracer_provider() -> TracerProvider | None:
     """Get the global TracerProvider instance.
 
     Returns:
-        TracerProvider: The global tracer provider
-
-    Raises:
-        RuntimeError: If called before initialization
+        TracerProvider if initialized, None otherwise
     """
     if _GLOBAL_TRACER_PROVIDER is None:
-        raise RuntimeError(
+        logger.warning(
             "TracerProvider not initialized. "
             "Call initialize_tracer_provider() during app startup."
         )
+        return None
     return _GLOBAL_TRACER_PROVIDER
 
 
@@ -258,22 +256,28 @@ def __init__(self, project_id: str, task_id: str):
             # Get the global shared tracer provider
             # This ensures only one BatchSpanProcessor is running
             provider = get_tracer_provider()
-
-            # Get tracer from the shared provider
-            # Use CAMEL version for instrumentation versioning
-            self.tracer = provider.get_tracer(
-                TRACER_NAME_WORKFORCE, camel.__version__
-            )
-            self.root_span = self.tracer.start_span(
-                f"{SPAN_WORKFORCE_EXECUTION}:{task_id}"
-            )
-            # Langfuse-specific attributes
-            self.root_span.set_attribute(ATTR_LANGFUSE_SESSION_ID, project_id)
-            tags = json.dumps(DEFAULT_LANGFUSE_TAGS.copy())
-            self.root_span.set_attribute(ATTR_LANGFUSE_TAGS, tags)
-            # Custom attributes
-            self.root_span.set_attribute(ATTR_PROJECT_ID, project_id)
-            self.root_span.set_attribute(ATTR_TASK_ID, task_id)
+            if provider is None:
+                # TracerProvider not initialized (e.g., app startup not
+                # completed or running in test environment)
+                self.enabled = False
+            else:
+                # Get tracer from the shared provider
+                # Use CAMEL version for instrumentation versioning
+                self.tracer = provider.get_tracer(
+                    TRACER_NAME_WORKFORCE, camel.__version__
+                )
+                self.root_span = self.tracer.start_span(
+                    f"{SPAN_WORKFORCE_EXECUTION}:{task_id}"
+                )
+                # Langfuse-specific attributes
+                self.root_span.set_attribute(
+                    ATTR_LANGFUSE_SESSION_ID, project_id
+                )
+                tags = json.dumps(DEFAULT_LANGFUSE_TAGS.copy())
+                self.root_span.set_attribute(ATTR_LANGFUSE_TAGS, tags)
+                # Custom attributes
+                self.root_span.set_attribute(ATTR_PROJECT_ID, project_id)
+                self.root_span.set_attribute(ATTR_TASK_ID, task_id)
 
         # Track active spans for task execution
         self.task_spans = {}

backend/tests/app/agent/factory/test_browser.py

@@ -35,6 +35,9 @@ def test_browser_agent_creation(sample_chat_data):
     _mod = "app.agent.factory.browser"
     with (
         patch(f"{_mod}.agent_model") as mock_agent_model,
+        patch(
+            f"{_mod}.get_working_directory", return_value="/tmp/test_workdir"
+        ),
         patch("asyncio.create_task"),
         patch(f"{_mod}.HumanToolkit") as mock_human_toolkit,
         patch(f"{_mod}.HybridBrowserToolkit") as mock_browser_toolkit,

backend/tests/app/agent/factory/test_developer.py

@@ -36,6 +36,9 @@ async def test_developer_agent_creation(sample_chat_data):
     _mod = "app.agent.factory.developer"
     with (
         patch(f"{_mod}.agent_model") as mock_agent_model,
+        patch(
+            f"{_mod}.get_working_directory", return_value="/tmp/test_workdir"
+        ),
         patch("asyncio.create_task"),
         patch(f"{_mod}.HumanToolkit") as mock_human_toolkit,
         patch(f"{_mod}.NoteTakingToolkit") as mock_note_toolkit,
@@ -82,6 +85,9 @@ async def test_developer_agent_with_multiple_toolkits(sample_chat_data):
     _mod = "app.agent.factory.developer"
     with (
         patch(f"{_mod}.agent_model") as mock_agent_model,
+        patch(
+            f"{_mod}.get_working_directory", return_value="/tmp/test_workdir"
+        ),
         patch("asyncio.create_task"),
         patch(f"{_mod}.HumanToolkit") as mock_human_toolkit,
         patch(f"{_mod}.NoteTakingToolkit") as mock_note_toolkit,

backend/tests/app/agent/factory/test_document.py

@@ -36,6 +36,9 @@ async def test_document_agent_creation(sample_chat_data):
     _mod = "app.agent.factory.document"
     with (
         patch(f"{_mod}.agent_model") as mock_agent_model,
+        patch(
+            f"{_mod}.get_working_directory", return_value="/tmp/test_workdir"
+        ),
         patch("asyncio.create_task"),
         patch(f"{_mod}.HumanToolkit") as mock_human_toolkit,
         patch(f"{_mod}.FileToolkit") as mock_file_toolkit,

backend/tests/app/agent/factory/test_multi_modal.py

@@ -35,6 +35,9 @@ def test_multi_modal_agent_creation(sample_chat_data):
     _mod = "app.agent.factory.multi_modal"
     with (
         patch(f"{_mod}.agent_model") as mock_agent_model,
+        patch(
+            f"{_mod}.get_working_directory", return_value="/tmp/test_workdir"
+        ),
         patch("asyncio.create_task"),
         patch(f"{_mod}.HumanToolkit") as mock_human_toolkit,
         patch(f"{_mod}.VideoDownloaderToolkit") as mock_video_toolkit,

backend/tests/app/agent/factory/test_social_media.py

@@ -36,6 +36,9 @@ async def test_social_media_agent_creation(sample_chat_data):
     mod = "app.agent.factory.social_media"
     with (
         patch(f"{mod}.agent_model") as mock_agent_model,
+        patch(
+            f"{mod}.get_working_directory", return_value="/tmp/test_workdir"
+        ),
         patch("asyncio.create_task"),
         patch(f"{mod}.WhatsAppToolkit") as mock_whatsapp_toolkit,
         patch(f"{mod}.TwitterToolkit") as mock_twitter_toolkit,

…t/component/test_environment_security.py …/tests/app/component/test_environment.pybackend/tests/unit/component/test_environment_security.py renamed to backend/tests/app/component/test_environment.py backend/tests/unit/component/test_environment_security.py renamed to backend/tests/app/component/test_environment.py

@@ -13,7 +13,7 @@
 # ========= Copyright 2025-2026 @ Eigent.ai All Rights Reserved. =========
 
 import os
-from unittest.mock import MagicMock, patch
+from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
 from fastapi import Response
@@ -50,13 +50,14 @@ async def test_post_chat_endpoint_success(
 
         with (
             patch(
-                "app.controller.chat_controller.create_task_lock",
+                "app.controller.chat_controller.get_or_create_task_lock",
                 return_value=mock_task_lock,
             ),
             patch(
                 "app.controller.chat_controller.step_solve"
             ) as mock_step_solve,
             patch("app.controller.chat_controller.load_dotenv"),
+            patch("app.controller.chat_controller.set_current_task_id"),
             patch("pathlib.Path.mkdir"),
             patch("pathlib.Path.home", return_value=MagicMock()),
         ):
@@ -71,9 +72,6 @@ async def mock_generator():
 
             assert isinstance(response, StreamingResponse)
             assert response.media_type == "text/event-stream"
-            mock_step_solve.assert_called_once_with(
-                chat_data, mock_request, mock_task_lock
-            )
 
     @pytest.mark.asyncio
     async def test_post_chat_sets_environment_variables(
@@ -84,13 +82,14 @@ async def test_post_chat_sets_environment_variables(
 
         with (
             patch(
-                "app.controller.chat_controller.create_task_lock",
+                "app.controller.chat_controller.get_or_create_task_lock",
                 return_value=mock_task_lock,
             ),
             patch(
                 "app.controller.chat_controller.step_solve"
             ) as mock_step_solve,
             patch("app.controller.chat_controller.load_dotenv"),
+            patch("app.controller.chat_controller.set_current_task_id"),
             patch("pathlib.Path.mkdir"),
             patch("pathlib.Path.home", return_value=MagicMock()),
             patch.dict(os.environ, {}, clear=True),
@@ -133,18 +132,24 @@ def test_improve_chat_success(self, mock_task_lock):
             # put_queue is invoked when creating the coroutine passed to asyncio.run
             mock_task_lock.put_queue.assert_called_once()
 
-    def test_improve_chat_task_done_error(self, mock_task_lock):
-        """Test improvement fails when task is done."""
+    def test_improve_chat_task_done_resets_to_confirming(self, mock_task_lock):
+        """Test improvement when task is done resets status to confirming."""
         task_id = "test_task_123"
         supplement_data = SupplementChat(question="Improve this code")
         mock_task_lock.status = Status.done
 
-        with patch(
-            "app.controller.chat_controller.get_task_lock",
-            return_value=mock_task_lock,
+        with (
+            patch(
+                "app.controller.chat_controller.get_task_lock",
+                return_value=mock_task_lock,
+            ),
+            patch("asyncio.run") as mock_run,
         ):
-            with pytest.raises(UserException):
-                improve(task_id, supplement_data)
+            response = improve(task_id, supplement_data)
+
+            assert mock_task_lock.status == Status.confirming
+            assert isinstance(response, Response)
+            assert response.status_code == 201
 
     def test_supplement_chat_success(self, mock_task_lock):
         """Test successful chat supplementation."""
@@ -244,16 +249,18 @@ def test_chat_endpoint_integration(
         """Test chat endpoint through FastAPI test client."""
         with (
             patch(
-                "app.controller.chat_controller.create_task_lock"
+                "app.controller.chat_controller.get_or_create_task_lock"
             ) as mock_create_lock,
             patch(
                 "app.controller.chat_controller.step_solve"
             ) as mock_step_solve,
             patch("app.controller.chat_controller.load_dotenv"),
+            patch("app.controller.chat_controller.set_current_task_id"),
             patch("pathlib.Path.mkdir"),
             patch("pathlib.Path.home", return_value=MagicMock()),
         ):
             mock_task_lock = MagicMock()
+            mock_task_lock.put_queue = AsyncMock()
             mock_create_lock.return_value = mock_task_lock
 
             async def mock_generator():
@@ -455,8 +462,12 @@ async def test_post_environment_setup_failure(
 
         with (
             patch(
-                "app.controller.chat_controller.create_task_lock"
+                "app.controller.chat_controller.get_or_create_task_lock"
             ) as mock_create_lock,
+            patch(
+                "app.controller.chat_controller.sanitize_env_path",
+                return_value="/tmp/fake.env",
+            ),
             patch(
                 "app.controller.chat_controller.load_dotenv",
                 side_effect=Exception("Env load failed"),