Skip to content

fix wrapper version for npm #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4pmtong merged 1 commit into from
Mar 6, 2026
Merged

fix wrapper version for npm #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions electron/main/utils/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,8 @@ export function ensureNpmWrappersForBrowserToolkit(
const eigentBinDir = path.join(os.homedir(), '.eigent', 'bin');
fs.mkdirSync(eigentBinDir, { recursive: true });

const wrapperVersion = '1';
// Store wrapper target so wrappers are recreated when venv path changes (e.g. app upgrade)
const wrapperVersion = `wrapper:${pythonPath}`;
const versionFile = path.join(eigentBinDir, '.npm_wrapper_version');
const storedVersion = fs.existsSync(versionFile)
? fs.readFileSync(versionFile, 'utf-8').trim()
Expand All @@ -958,10 +959,14 @@ export function ensureNpmWrappersForBrowserToolkit(
process.platform === 'win32' ? 'npx.cmd' : 'npx'
);

// Recreate wrappers when: version changed, wrappers missing, or existing shebang points to wrong Python
const needsUpdate =
storedVersion !== wrapperVersion ||
!fs.existsSync(npmWrapper) ||
!fs.existsSync(npxWrapper);
!fs.existsSync(npxWrapper) ||
(process.platform !== 'win32' &&
fs.existsSync(npmWrapper) &&
!fs.readFileSync(npmWrapper, 'utf-8').startsWith(`#!${pythonPath}`));

if (needsUpdate) {
try {
Expand Down