Improve settings UX and tests#1484
Conversation
58aedae to
4a2b260
Compare
|
Thanks @kiannidev for contribution! could @a7m-1st help review it? |
|
Can you give a screenshot for your UI changes? |
Thanks for the review @bytecii .
This PR primarily improves **settings behavior and reliability**, so visual UI changes are intentionally minimal.
What changed visually
What changed functionally (main scope)
|
…nd-tests Made-with: Cursor # Conflicts: # src/pages/Setting/Privacy.tsx
|
Hi, @bytecii |
|
Hi @kiannidev, thanks a lot for the contribution and for sticking with this through the merge conflicts — appreciate the effort here! After review, we felt the proxy loading/disabled-state handling and the extra helper text are a bit redundant with the existing design (the Save-until-changed behavior already communicates the "no-op" state, and the helper text mostly repeats the existing description). We think a better approach would be adding a Reset button to the proxy setting, so users can quickly revert an in-progress edit back to the last-saved value — that would give a nicer UX win than the current changes. We've opened a new issue for this, and you're very welcome to take it on if you're interested — happy to have you continue building on this work! #1728 Thanks again for the PR and the test coverage you added along the way. |

Summary