add camel_log and attachments#1546
Merged
fengju0213 merged 3 commits intomainfrom Apr 10, 2026
Merged
Conversation
fengju0213
reviewed
Apr 10, 2026
Collaborator
fengju0213
left a comment
fengju0213
left a comment
There was a problem hiding this comment.
overall，looks good！
Should we keep the original camel_log directory structure? I’ve already opened a PR for it. In that case, does the server-side logic also need to be updated accordingly?
| ): Promise<UploadOutcome[]> { | ||
| const results: UploadOutcome[] = []; | ||
|
|
||
| for (const file of files) { |
Collaborator
There was a problem hiding this comment.
Is the use of serial uploads here intentional, considering the possibility of high concurrency?
fengju0213
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #
Description
Testing Evidence (REQUIRED)
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement