fix-trigger-hour-dropdown#1591
Open
ultrahighsuper wants to merge 2 commits intoeigent-ai:mainfrom
Open
Conversation
Author
|
@4pmtong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1590
Description
Fixes a UI bug in the Edit Trigger schedule panel where the Hour/Minute dropdown closes before selection when the user interacts with the dropdown's right-side scrollbar/slider.
Root cause was the input blur handler always closing the dropdown after a timeout, even during valid dropdown interaction.
Change made in
src/components/ui/input-select.tsx:interactingWithDropdownRef) set ononMouseDownCapturefor the dropdown panel.mouseupwhile dropdown is open.This keeps the dropdown open during scrollbar interaction and still allows normal outside-click close behavior.
Testing Evidence (REQUIRED)
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement
2026-04-29_09h07_02.mp4