fix: map deepseek and z.ai to openai-compatible-model in platform alias#1615
Open
nudiltoys-cmyk wants to merge 1 commit intoeigent-ai:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1578
Closes #1556
Description
both issues report BYOK validation failing with "unknown model platform: "
deepseekfalls throughPLATFORM_ALIAS_MAPPINGbecause there's no entry, so camel'sModelPlatformTypereceives the bare string"deepseek"and raisesz.aiis currently mapped to"zhipu"which camel also doesn't recognizeboth providers expose openai-compatible apis and
src/lib/llm.tsalready sends the platform strings as-is, so the fix is two entries in the mapping: changez.aifromzhiputoopenai-compatible-model, and adddeepseekmapped to the same targetmatches the existing pattern used by
grok,ModelArk, andllama.cppdiscussed first on #1578
the issue author proposed exactly this fix in the body, and i confirmed the change locally before opening the pr
Testing Evidence (REQUIRED)
ran the full backend suite per
.github/workflows/test.yml:ran ruff against the whole backend per
.github/workflows/pre-commit.yml, version pinned to match.pre-commit-config.yaml(ruff-pre-commit v0.14.3):targeted run on the touched test file:
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement