Conversation
|
Perhaps you can remove the /context-files uploaded @Douglasymlai ? |
|
@a7m-1st Yea, thanks for the recommendation. I haven't noticed, it got so many random files created. I will update it. |
|
all right cool, thanks @Douglasymlai |
Douglasymlai
requested review from
a7m-1st
and removed request for
nitpicker55555
|
Hi @a7m-1st, I just removed the unnecessary files. Can you help testing how does this branch looks like on the Wins device? The glass effect I added is only for Mac device. It should not change anything for the wins device. |
|
Hi there @Douglasymlai , this is how eigent looks like in this branch: 
|
|
is this how it is supposed to look like or anything in particular to check ? @Douglasymlai |
|
@a7m-1st Yep, it doesn't change too much for the windows device. Thanks for testing! The style change was made for macos device. |
|
I have just double checked the changes for this branch. I think it should be good now. If you could help review it again @a7m-1st thanks! |
Douglasymlai
requested review from
4pmtong
and removed request for
Wendong-Fan
|
Hi there @Douglasymlai after a quick test, I guess we need to have windows native rounded corners in another pr. The last commit isn't making justice 🥲 
|
|
If this branch only changes the macOS display behavior, then from a frontend functional acceptance perspective it meets expectations. |
|
Got it. @a7m-1st I will open another issue for Windows appearance enhancement. |
|
No issues, just pointing it out thanks @Douglasymlai and @Pakchoioioi |
|
hi @Douglasymlai could you fix the conflicts first? Maybe you could try the code format after #878 is merged into main. |
|
@4pmtong Yea, no problem I will resolve the conflicts first. |
4pmtong
left a comment
4pmtong
left a comment
There was a problem hiding this comment.
LGTM. thanks @Douglasymlai
4 participants
Description
Added new package to align the electron style with design files for MacOS system
What is the purpose of this pull request?