enhance: browser external cdp a7m#849
Closed
a7m-1st wants to merge 5 commits intofeat/browser_external_cdpfrom
Closed
enhance: browser external cdp a7m#849a7m-1st wants to merge 5 commits intofeat/browser_external_cdpfrom
a7m-1st wants to merge 5 commits intofeat/browser_external_cdpfrom
Conversation
Collaborator
|
Thank you too much for your review! |
Collaborator
|
Hi! When you finish your review please tell me, thanks! |
Collaborator
Author
|
Will be continuing in a moment 👍 |
Collaborator
Author
|
Hi there @nitpicker55555 should be done for the enhancements. Just left two main concerns on the main PR |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi there @nitpicker55555 , went through a quick review of the electron side and it looks good, I just need some time to check the backend logic. I will be committing to this branch.
What is the purpose of this pull request?