Skip to content

enhance: cleanup env on close session#889

Closed
a7m-1st wants to merge 3 commits intomainfrom
enhance/cleanup-terminal-env
Closed

enhance: cleanup env on close session#889
a7m-1st wants to merge 3 commits intomainfrom
enhance/cleanup-terminal-env

Conversation

@a7m-1st
Copy link
Copy Markdown
Collaborator

@a7m-1st a7m-1st commented Jan 16, 2026

fixes #883

Description

  • Track toolkits for cleanup in registered_toolkits
  • Enhance cleanup function to remove env too in TerminalToolkit extension

Notes

image
  • Perhaps a smart trick to increase the speed of the env setup is to use the parent as reference path on UV? --cache-dir and/or direction all task instances to the same path via uv --directory ./shared_terminal per project?

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@a7m-1st a7m-1st requested a review from Wendong-Fan January 16, 2026 14:02
@a7m-1st
Copy link
Copy Markdown
Collaborator Author

a7m-1st commented Jan 16, 2026

On timeout
image

@Wendong-Fan
Copy link
Copy Markdown
Contributor

hey @a7m-1st @nitpicker55555 submitted PR #971 based on your work and it's been merged, I will close this one, thanks for pointing out this performance issue and fix this!

@a7m-1st
Copy link
Copy Markdown
Collaborator Author

a7m-1st commented Jan 20, 2026

all right cool, thanks sm @Wendong-Fan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] Why does each task run create a new virtual environment? It's taking up too much disk space.

2 participants