Support multiple contents in sampling results (using DTOs)#3
Open
eiriktsarpalis wants to merge 1 commit intomainfrom
Open
Support multiple contents in sampling results (using DTOs)#3eiriktsarpalis wants to merge 1 commit intomainfrom
eiriktsarpalis wants to merge 1 commit intomainfrom
Conversation
jeffhandley
reviewed
Sep 16, 2025
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
This looks very good to me. The approach looks like it would scale very nicely without adding any compensating logic in unrelated places to the codebase.
eiriktsarpalis
force-pushed
the
schema-breaking-changes-dto
branch
from
6d135bb to
0e1bae4
Compare
eiriktsarpalis
pushed a commit
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #2, this PR showcases how we could account for potential future breaking changes in the MCP protocol. It introduces two versioned DTOs corresponding to the model type. It also introduces an
IMcpModelSerializer<T>interface that serves as the basis for dynamic DTO selection based on the current session via a set of shared combinators.