Add fast-path in NullnessPropagationTreeAnnotator.visitNewClass: return if type already has @nonnull.

Author: zyf265600

checker/src/main/java/org/checkerframework/checker/nullness/NullnessNoInitAnnotatedTypeFactory.java

@@ -113,9 +113,6 @@ public class NullnessNoInitAnnotatedTypeFactory
     private final ExecutableElement mapGet =
             TreeUtils.getMethod("java.util.Map", "get", 1, processingEnv);
 
-    // High-level optimization: cache entire addComputedTypeAnnotations processing flow
-    private final java.util.Set<String> fullyProcessedTrees = new java.util.HashSet<>();
-
     // List is in alphabetical order.  If you update it, also update
     // ../../../../../../../../docs/manual/nullness-checker.tex
     // and make a pull request for variables NONNULL_ANNOTATIONS and BASE_COPYABLE_ANNOTATIONS in
@@ -486,19 +483,6 @@ protected void replacePolyQualifier(AnnotatedTypeMirror lhsType, Tree context) {
         }
     }
 
-    @Override
-    protected void addComputedTypeAnnotations(Tree tree, AnnotatedTypeMirror type) {
-        if (tree != null && tree instanceof NewClassTree) {
-            String treeKey = tree.toString();
-            if (fullyProcessedTrees.contains(treeKey)) {
-                return;
-            }
-            fullyProcessedTrees.add(treeKey);
-        }
-
-        super.addComputedTypeAnnotations(tree, type);
-    }
-
     @Override
     protected NullnessNoInitAnalysis createFlowAnalysis() {
         return new NullnessNoInitAnalysis(checker, this);
@@ -750,8 +734,9 @@ public Void visitUnary(UnaryTree tree, AnnotatedTypeMirror type) {
         // explicit nullable annotations are left intact for the visitor to inspect.
         @Override
         public Void visitNewClass(NewClassTree tree, AnnotatedTypeMirror type) {
-            // The constructor return type should already be NONNULL, so in most cases this will do
-            // nothing.
+            if (type.hasEffectiveAnnotation(NONNULL)) {
+                return null;
+            }
             type.addMissingAnnotation(NONNULL);
             return null;
         }
@@ -761,7 +746,9 @@ public Void visitNewClass(NewClassTree tree, AnnotatedTypeMirror type) {
         @Override
         public Void visitNewArray(NewArrayTree tree, AnnotatedTypeMirror type) {
             super.visitNewArray(tree, type);
-            type.addMissingAnnotation(NONNULL);
+            if (!type.hasEffectiveAnnotation(NONNULL)) {
+                type.addMissingAnnotation(NONNULL);
+            }
             return null;
         }