performance(calendar): Prevent unnecessary update on day component#1
Open
abdallaayman21 wants to merge 2 commits into
Open
performance(calendar): Prevent unnecessary update on day component#1abdallaayman21 wants to merge 2 commits into
abdallaayman21 wants to merge 2 commits into
Conversation
Collaborator
Author
|
I will be using the |
Collaborator
Author
|
We could consider this as a temporary fix for us, but I think it we could make it better, as I think comparing the |
feat(calendar_list): unable to render static header and footer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendars where taking too long to update after a day is pressed, this was due unnecessary re-renders on the day component.
The re-renders are triggered due to comparing the
onPressfunctions as well astheme.Comparing the
onPressfunction will alway return false if theonPressfunction usesuseCallbackor any similar hook that will update the fuction as it changes it's address in the memory therefore triggering a re-render.However, comparing
onPressoronLongPressis crucial for theExpandableCalendarcomponent as it'sonPressfunction has multiple jobs like closing the calendar on day select if it was true. If we stopped comparing theonPressoronLongPressfunctions theExpandableCalendarcloseOnDayPresswon't work as expected.TODO:
closeOnDayPresswork without having to re-render all of the day components.