Coverity: Untrusted divisor

ejohnstown · ejohnstown · commit 6f23f246466f · 2025-07-14T16:05:20.000-07:00
1. Add typecast to assignment in ato32().

Fixes CID: 572837
diff --git a/src/misc.c b/src/misc.c
@@ -74,7 +74,7 @@ STATIC INLINE word32 min(word32 a, word32 b)
 /* convert opaque to 32 bit integer */
 STATIC INLINE void ato32(const byte* c, word32* u32)
 {
-    *u32 = (c[0] << 24) | (c[1] << 16) | (c[2] << 8) | c[3];
+    *u32 = ((word32)(c[0] << 24) | (c[1] << 16) | (c[2] << 8) | c[3]);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ STATIC INLINE word32 min(word32 a, word32 b)`
`74`	`74`	`/* convert opaque to 32 bit integer */`
`75`	`75`	`STATIC INLINE void ato32(const byte* c, word32* u32)`
`76`	`76`	`{`
`77`		`- *u32 = (c[0] << 24) \| (c[1] << 16) \| (c[2] << 8) \| c[3];`
	`77`	`+ *u32 = ((word32)(c[0] << 24) \| (c[1] << 16) \| (c[2] << 8) \| c[3]);`
`78`	`78`	`}`
`79`	`79`
`80`	`80`