KeyboardInteractive Fix

1. Snip out some extraneous states from the server handshake tracking
   for accept.
2. Change sending the keyboard interactive info response to a reaction
   to a request.

Author: ejohnstown

src/internal.c

@@ -7898,10 +7898,7 @@ static int DoUserAuthSuccess(WOLFSSH* ssh,
         return ret;
     }
 
-    if (ssh->serverState == SERVER_USERAUTH_ACCEPT_KEYBOARD)
-        ssh->serverState = SERVER_USERAUTH_ACCEPT_KEYBOARD_DONE;
-    else
-        ssh->serverState = SERVER_USERAUTH_ACCEPT_DONE;
+    ssh->serverState = SERVER_USERAUTH_ACCEPT_DONE;
 
     WLOG(WS_LOG_DEBUG, "Leaving DoUserAuthSuccess(), ret = %d", ret);
     return ret;
@@ -7954,7 +7951,6 @@ static int DoUserAuthInfoRequest(WOLFSSH* ssh, byte* buf, word32 len,
     if (ssh == NULL || buf == NULL || len == 0 || idx == NULL)
         ret = WS_BAD_ARGUMENT;
 
-
     if (ret == WS_SUCCESS) {
         begin = *idx;
         ret = GetStringAlloc(ssh->ctx->heap, (char**)&authName, buf, len,
@@ -8029,8 +8025,9 @@ static int DoUserAuthInfoRequest(WOLFSSH* ssh, byte* buf, word32 len,
         WFREE(language, ssh->ctx->heap,  DYNTYPE_STRING);
     }
 
-    if (ret == WS_SUCCESS)
-        ssh->serverState = SERVER_USERAUTH_ACCEPT_KEYBOARD;
+    if (ret == WS_SUCCESS) {
+        ret = SendUserAuthKeyboardResponse(ssh);
+    }
 
     WLOG(WS_LOG_DEBUG, "Leaving DoUserAuthInfoRequest(), ret = %d", ret);
 

src/ssh.c

@@ -890,28 +890,6 @@ int wolfSSH_connect(WOLFSSH* ssh)
                     return WS_FATAL_ERROR;
                 }
             }
-
-            while (ssh->serverState == SERVER_USERAUTH_ACCEPT_KEYBOARD) {
-                if ( (ssh->error = SendUserAuthKeyboardResponse(ssh)) <
-                    WS_SUCCESS) {
-                    WLOG(WS_LOG_DEBUG, connectError, "CLIENT_USERAUTH_SENT",
-                        ssh->error);
-                    return WS_FATAL_ERROR;
-                }
-                ssh->serverState = SERVER_USERAUTH_ACCEPT_KEYBOARD_NEXT;
-                while (
-                    (ssh->serverState < SERVER_USERAUTH_ACCEPT_KEYBOARD_DONE) &&
-                    (ssh->serverState != SERVER_USERAUTH_ACCEPT_KEYBOARD) &&
-                    (ssh->serverState != SERVER_USERAUTH_ACCEPT_DONE)) {
-
-                    if (DoReceive(ssh) < WS_SUCCESS) {
-                        WLOG(WS_LOG_DEBUG, connectError,
-                            "CLIENT_USERAUTH_SENT", ssh->error);
-                        return WS_FATAL_ERROR;
-                    }
-                }
-            }
-
             ssh->connectState = CONNECT_SERVER_USERAUTH_ACCEPT_DONE;
             WLOG(WS_LOG_DEBUG, connectState, "SERVER_USERAUTH_ACCEPT_DONE");
             NO_BREAK;

wolfssh/internal.h

@@ -1154,9 +1154,6 @@ enum ServerStates {
     SERVER_KEXINIT_DONE,
     SERVER_USERAUTH_REQUEST_DONE,
     SERVER_USERAUTH_ACCEPT_DONE,
-    SERVER_USERAUTH_ACCEPT_KEYBOARD,
-    SERVER_USERAUTH_ACCEPT_KEYBOARD_NEXT,
-    SERVER_USERAUTH_ACCEPT_KEYBOARD_DONE,
     SERVER_CHANNEL_OPEN_DONE,
     SERVER_DONE
 };