Skip to content

Add build status#11

Open
markddavidoff wants to merge 11 commits into
ekmartin:masterfrom
markddavidoff:add-build-status
Open

Add build status#11
markddavidoff wants to merge 11 commits into
ekmartin:masterfrom
markddavidoff:add-build-status

Conversation

@markddavidoff
Copy link
Copy Markdown
Collaborator

@markddavidoff markddavidoff commented Oct 16, 2018

Screenshot of what it looks like:
image

@ekmartin
Copy link
Copy Markdown
Owner

ekmartin commented Nov 7, 2018

Sorry about the delay here — this is pretty cool! Could you share a screenshot?

@ekmartin ekmartin reopened this Nov 7, 2018
Comment thread slack_pull_reminder.py Outdated
Comment thread slack_pull_reminder.py Outdated
@markddavidoff
Copy link
Copy Markdown
Collaborator Author

markddavidoff commented Nov 27, 2018

@ekmartin I need a new review before this stuff can get merged but I'm also considering adding the icons to this repo as well as adding instructions on how to add slack emoji to the setup instructions as the default ones look pretty bad.

At which point I think setup might be easier if instead of an emoji i make it a url to an image hosted somewhere, opinions?

@markddavidoff
Copy link
Copy Markdown
Collaborator Author

@ekmartin yeah i guess Review required permission is still set even for collaborators.

@markddavidoff
Copy link
Copy Markdown
Collaborator Author

hey @ekmartin I have a lot of plans for stuff I want to do with this repo, and you have the primo pip slug so I'd rather continue the project, would you consider moving this repo to an open source org like https://jazzband.co/ and adding me as a maintainer? Otherwise I'll be starting my own fork.

@ekmartin
Copy link
Copy Markdown
Owner

ekmartin commented Dec 2, 2018

If we can find a set of default emojis that look alright here I'd prefer not having configuration options for this at all. Opinionated is usually better than overly configurable and I think it's worth trying to keep the options to a minimum.

Regarding the maintainer question: I added you as a collaborator a while back, but it says it's awaiting your response. With that being said, I still prefer that all changes go through a pull request reviewed by at least one person. I'd definitely be open to moving the project to something like Jazzband, but I don't think that would change anything in terms of reviews and merging code — it would also definitely need things like tests first to follow the Jazzband guidelines.

image

@markddavidoff
Copy link
Copy Markdown
Collaborator Author

Yea, you're right, this may be too much customizability.... hadn't thought of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants