fix: auto-detect system architecture instead of hardcoding#8708
Merged
cheeseandcereal merged 1 commit intoeksctl-io:mainfrom Apr 29, 2026
Merged
fix: auto-detect system architecture instead of hardcoding#8708cheeseandcereal merged 1 commit intoeksctl-io:mainfrom
cheeseandcereal merged 1 commit intoeksctl-io:mainfrom
Conversation
Contributor
|
Hello cloudsmithy 👋 Thank you for opening a Pull Request in |
Contributor
Author
|
Hi team, just a gentle ping on this PR. It improves cross-platform compatibility for the setup script. Could you please help to run the CI checks when you have a moment? Thanks! |
cheeseandcereal
approved these changes
Apr 29, 2026
Member
cheeseandcereal
left a comment
cheeseandcereal
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded
ARCH=amd64with dynamic architecture detectionusing
uname -m, improving cross-platform compatibility.x86_64→amd64aarch64→arm64(Linux ARM)arm64passes through as-is (macOS Apple Silicon)This removes the need for users to manually edit the ARCH variable
based on their system.