Skip to content

Remove deprecated "$COMPLETE" variable from version template for release drafter workflow#8721

Merged
cheeseandcereal merged 1 commit intomainfrom
fix-release-drafter-v7-version-template
Apr 29, 2026
Merged

Remove deprecated "$COMPLETE" variable from version template for release drafter workflow#8721
cheeseandcereal merged 1 commit intomainfrom
fix-release-drafter-v7-version-template

Conversation

@cheeseandcereal
Copy link
Copy Markdown
Member

Description

Fix: Remove the version-template override. The release-drafter v7 default is $MAJOR.$MINOR.$PATCH$PRERELEASE, which matches the old v6 $COMPLETE behavior for stable releases and also keeps any future prerelease (-rc.N) rendering correct. An equivalent valid override version-template: '$MAJOR.$MINOR.$PATCH' would also work, but dropping the override is cleaner.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added the kind/maintenance related to maintenance of the repo/ci/tech debt/etc label Apr 29, 2026
@cheeseandcereal cheeseandcereal enabled auto-merge (squash) April 29, 2026 18:24
@github-actions
Copy link
Copy Markdown
Contributor

Hello cheeseandcereal 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@cheeseandcereal cheeseandcereal added the skip-release-notes Causes PR not to show in release notes label Apr 29, 2026
@cheeseandcereal cheeseandcereal merged commit 4b71d03 into main Apr 29, 2026
13 of 15 checks passed
@cheeseandcereal cheeseandcereal deleted the fix-release-drafter-v7-version-template branch April 29, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/maintenance related to maintenance of the repo/ci/tech debt/etc skip-release-notes Causes PR not to show in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants