File::getSubDirectories

Author: medilies

CONTRIBUTING.md

@@ -21,3 +21,7 @@ Don't worry if your code styling isn't perfect! `Fix PHP code style issues` acti
 ## Testing
 
 The added code needs to be well tested and not reduce the coverage. Feel free to use `Pest` or `PHPUnit`.
+
+## TODO
+
+-   Custom exceptions

src/LangFolder/LangFolder.php

@@ -52,7 +52,7 @@ protected function setLocaleLoadersCollection(): void
     {
         $this->localeLoadersCollection = [];
 
-        foreach ($this->directory->getDirectoryContent() as $lang => $abs_path) {
+        foreach ($this->directory->getSubDirectories() as $lang => $abs_path) {
             $this->localeLoadersCollection[$lang] = $this->localeFolderFactory->make($abs_path);
         }
     }
@@ -66,7 +66,7 @@ protected function setLocaleLoadersCollection(): void
      */
     public function getLocalesList(): array
     {
-        return array_keys($this->directory->getDirectoryContent());
+        return array_keys($this->directory->getSubDirectories());
     }
 
     /**

src/Strategies/File.php

@@ -98,18 +98,30 @@ public function getDirectoryContent(): array
         return $this->directoryContent;
     }
 
+    /**
+     * 'Dir_name/locale' => 'dir_absolute_path'
+     */
+    public function getSubDirectories(): array
+    {
+        $directoryContent = $this->getDirectoryContent();
+
+        return array_filter(
+            $directoryContent,
+            fn ($abs_path) => is_dir($abs_path),
+            ARRAY_FILTER_USE_BOTH
+        );
+    }
+
     /**
      * 'JSON_name' => 'file_absolute_path'
      */
     public function getDirectoryJsonContent(): array
     {
-        if (! $this->isDir()) {
-            throw new Exception("This object isn't a directory");
-        }
+        $directoryContent = $this->getDirectoryContent();
 
         return array_filter(
-            $this->directoryContent,
-            fn ($file_name, $abs_path) => is_json($file_name),
+            $directoryContent,
+            fn ($abs_path, $file_name) => is_json($file_name),
             ARRAY_FILTER_USE_BOTH
         );
     }

tests/unit/Strategies/FileTest.php

@@ -66,11 +66,14 @@
     ->expect(fn () => (new File('composer.json'))->getDirectoryContent())
     ->throws(\Exception::class, 'This object isn\'t a directory');
 
+test('getSubDirectories')
+    ->expect((new File())->getSubDirectories())
+    ->not->toContain(realpath(__DIR__.'/../../../composer.json'))
+    ->toContain(realpath(__DIR__.'/../../../src'))
+    ->toContain(realpath(__DIR__.'/../../../tests'))
+    ->toContain(realpath(__DIR__.'/../../../vendor'));
+
 test('getDirectoryJsonContent')
     ->expect((new File())->getDirectoryJsonContent())
     ->toHaveCount(1)
     ->toContain(realpath(__DIR__.'/../../../composer.json'));
-
-it('throws an exception for calling getDirectoryJsonContent on a file')
-    ->expect(fn () => (new File('composer.json'))->getDirectoryJsonContent())
-    ->throws(\Exception::class, 'This object isn\'t a directory');