Update reset.css#92
Open
Arsalan2078 wants to merge 1 commit into
Open
Conversation
Contributor
|
And the comments are usually stripped when bundling anyways, so they don't make it into the final result that gets shipped down the wire to end users. This PR in the current form mustn't be merged. |
elektronik2k5
suggested changes
Nov 24, 2024
Contributor
elektronik2k5
left a comment
elektronik2k5
left a comment
There was a problem hiding this comment.
We need the comments for documentation purposes. If the concern is bundle size then:
- These texts weigh next to nothing when compressed over the wire (which is the industry standard)
- Bundlers strip comments already in most configurations
Author
|
I apologize! I did not intend to merge it like that. It's been a month ago, but I thought i forked the repository, so it would only have my changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.