Fixed qualified type parsing in for-loop variable annotations#20
Open
dreed-sd wants to merge 1 commit into
Open
Fixed qualified type parsing in for-loop variable annotations#20dreed-sd wants to merge 1 commit into
dreed-sd wants to merge 1 commit into
Conversation
elamaunt
reviewed
Apr 23, 2026
| } | ||
| else | ||
| { | ||
| if (c == '[' && (_pendingTypeName.IsArray || _pendingTypeName.IsDictionary)) |
Owner
There was a problem hiding this comment.
Nested parsing bypasses the core idea of delegating parsing to subnodes. This is only allowed for resolvers in special cases. The structure must manage parsing itself, otherwise the node takes on too much responsibility. The appropriate resolver must be called here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19