fix: stop workflow-run pagination at --since boundary before conclusion filter (#1248)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: github-actions[bot]

scripts/fetch-workflow-logs.py

@@ -87,11 +87,11 @@ def list_workflow_runs(repo: str, workflow: str, token: str, since: str | None,
     runs = []
     for batch in _iter_workflow_run_pages(repo=repo, workflow=workflow, token=token):
         for run in batch:
-            if not _run_matches_conclusion(run, conclusion):
-                continue
             if _is_before_since_boundary(run, since):
                 # Runs are sorted newest-first; once we go past since, stop paging
                 return runs
+            if not _run_matches_conclusion(run, conclusion):
+                continue
             if _is_after_until_boundary(run, until_normalized):
                 continue
             runs.append(run)

tests/test_fetch_workflow_logs.py

@@ -39,6 +39,31 @@ def fake_github_api(path, token, accept="application/vnd.github+json"):
     assert len(calls) == 2
 
 
+def test_list_workflow_runs_stops_at_since_boundary_before_conclusion_filter(monkeypatch):
+    module = _load_module()
+    calls = []
+
+    def fake_github_api(path, token, accept="application/vnd.github+json"):
+        calls.append(path)
+        if path.endswith("page=1"):
+            return b'{"workflow_runs":[{"id":101,"created_at":"2024-12-31T00:00:00Z","conclusion":"success"}]}'
+        return b'{"workflow_runs":[{"id":100,"created_at":"2024-12-30T00:00:00Z","conclusion":"failure"}]}'
+
+    monkeypatch.setattr(module, "github_api", fake_github_api)
+    runs = module.list_workflow_runs(
+        repo="elastic/ai-github-actions",
+        workflow="ci.yml",
+        token="x",
+        since="2025-01-01T00:00:00Z",
+        until=None,
+        conclusion="failure",
+        last=20,
+    )
+
+    assert runs == []
+    assert len(calls) == 1
+
+
 def test_list_workflow_runs_inclusive_date_only_until(monkeypatch):
     module = _load_module()