Skip to content

Commit e29105c

Browse files
authored
Apply suggestions from code review
1 parent d2acdd0 commit e29105c

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

tests/contrib/opentelemetry/tests.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ def test_span_links(tracer: Tracer):
157157

158158

159159
def test_set_status_with_status_object(tracer: Tracer):
160-
"""Test set_status with Status object (original API)"""
161160
with tracer.start_as_current_span("test") as span:
162161
span.set_status(Status(StatusCode.OK))
163162

@@ -167,7 +166,6 @@ def test_set_status_with_status_object(tracer: Tracer):
167166

168167

169168
def test_set_status_with_status_code(tracer: Tracer):
170-
"""Test set_status with StatusCode enum (new API)"""
171169
with tracer.start_as_current_span("test") as span:
172170
span.set_status(StatusCode.ERROR)
173171

@@ -177,7 +175,6 @@ def test_set_status_with_status_code(tracer: Tracer):
177175

178176

179177
def test_set_status_with_status_code_and_description(tracer: Tracer):
180-
"""Test set_status with StatusCode enum and optional description"""
181178
with tracer.start_as_current_span("test") as span:
182179
span.set_status(StatusCode.OK, "Everything is fine")
183180

@@ -187,7 +184,6 @@ def test_set_status_with_status_code_and_description(tracer: Tracer):
187184

188185

189186
def test_set_status_unset(tracer: Tracer):
190-
"""Test set_status with UNSET status code"""
191187
with tracer.start_as_current_span("test") as span:
192188
span.set_status(StatusCode.UNSET)
193189

@@ -205,3 +201,6 @@ def test_set_status_on_span(tracer: Tracer):
205201
client = tracer.client
206202
span_event = client.events[constants.SPAN][0]
207203
assert span_event["outcome"] == "failure"
204+
205+
206+
# TODO Add some span subtype testing?

0 commit comments

Comments
 (0)